From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 2/3] gc: rely on minimal vclock components instead of signatures
Date: Sat, 11 Apr 2020 18:04:42 +0200 [thread overview]
Message-ID: <bd6fa57f-3ee7-be36-bd70-cc9fc37a279a@tarantool.org> (raw)
In-Reply-To: <769253CE-47DB-4FEF-BDB2-046799B15682@tarantool.org>
Hi! Thanks for the answers!
gc_add_checkpoint() and gc_consumer_advance() still use sum().
Is it ok?
I see gc_consumer_advance() compares vclocks of two neighbour
consumers using sum() to check tree's invariant, even though
the invariant is not related to sum() anymore.
Please, check all the other vclock_sum() invocations too,
just in case.
next prev parent reply other threads:[~2020-04-11 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 15:49 [Tarantool-patches] [PATCH v6 0/3] replication: fix local space tracking Serge Petrenko
2020-04-07 15:49 ` [Tarantool-patches] [PATCH v6 1/3] replication: omit 0-th vclock component in replication responses Serge Petrenko
2020-04-09 23:08 ` Vladislav Shpilevoy
2020-04-10 12:25 ` Serge Petrenko
2020-04-11 16:05 ` Vladislav Shpilevoy
2020-04-13 10:12 ` Serge Petrenko
2020-04-07 15:49 ` [Tarantool-patches] [PATCH v6 2/3] gc: rely on minimal vclock components instead of signatures Serge Petrenko
2020-04-09 23:08 ` Vladislav Shpilevoy
2020-04-10 12:25 ` Serge Petrenko
2020-04-11 16:04 ` Vladislav Shpilevoy [this message]
2020-04-13 10:12 ` Serge Petrenko
2020-04-07 15:49 ` [Tarantool-patches] [PATCH v6 3/3] box: start counting local space requests separately Serge Petrenko
2020-04-13 14:38 ` [Tarantool-patches] [PATCH v6 0/3] replication: fix local space tracking Vladislav Shpilevoy
2020-04-16 13:49 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd6fa57f-3ee7-be36-bd70-cc9fc37a279a@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 2/3] gc: rely on minimal vclock components instead of signatures' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox