Re: [Tarantool-patches] [PATCH] rocks: forward options to luarocks

[lvasiliev <lvasiliev@tarantool.org>]

Hi, thanks for the feedback.

On 01.04.2020 13:44, Oleg Babin wrote:
> Hi! Thanks for your patch I have several comments.
> 
> On 26/03/2020 01:01, Leonid Vasiliev wrote:
>  > From: Leonid <lvasiliev@tarantool.org>
>  >
>  > https://github.com/tarantool/tarantool/issues/4629
>  > 
> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4629-forward-flags
>  >
>  > Corresponding thread 
> https://lists.tarantool.org/pipermail/tarantool-patches/2020-March/015143.html 
> 
>  >
>  > @Changelog
> Please put branch, issue and changelog under "---". This should not be a 
> part of commit message.
>  > Chdir has been moved to luarocks.
> 
> It's quite important thing to preserve backward compatibility.
> How it works now:
> ```
> tarantoolctl rocks make --chdir ../tracing
> 
> Warning: variable CFLAGS was not passed in build_variables
> mkdir -p doc
> tracing scm-1 is now installed in 
> /Users/o.babin/Projects/tarantool/.rocks (license: BSD)
> ```
> 
> How it looks on your branch:
> ```
> ./src/tarantool ./extra/dist/tarantoolctl rocks make --chdir ../tracing
> 
> Error: Invalid argument: unknown flag --chdir. See --help.
> ```
> 
> And I don't see any mentions of this option in "rocks --help". May be I 
> do something wrong? But make sure that behaviour of this option was not 
> changed. It's quite important for solutions.
As I understand it, you use luarocks from the system, you need use 
luaroks from the repo (use export LUA_PATH=...).
> 
> ---
> Oleg Babin