Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>,
	Sergey Bronnikov <estetus@gmail.com>,
	Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com
Subject: Re: [Tarantool-patches] [PATCH luajit][v2] cmake: replace prove with CTest
Date: Tue, 12 Mar 2024 10:09:43 +0300	[thread overview]
Message-ID: <bb811f2c-4c9b-49ee-af07-3d16d4ca5014@tarantool.org> (raw)
In-Reply-To: <Ze4SG_i0yRhmmUdk@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]


On 3/10/24 23:03, Igor Munkin wrote:
> Sergey,
> I've pushed the new version[1], tweaked and rebased onto the bleeding
> master, with a tiny fixup for LuaJIT tests series on the top of the
> branch (I left no comments, but the fix relates to Sergey adventures
> with CMake lists).
> Unfortunately, I automatically squashed all the
> tweaks made to the original commit, but I hope it's not a problem.
> Besides, there are still some issues with the new LuaJIT C tests being
> run with the sanitizers. I hope Sergey will help you to figure out
> what's going wrong.
> When all the issues are resoluved, please send the new version of the
> patch to the ml, to get all the required LGTMs.

v3 is here [1]. Please review and respond within an acceptable time frame.


> [1]:https://github.com/tarantool/luajit/commit/7d71534

[-- Attachment #2: Type: text/html, Size: 2029 bytes --]

      reply	other threads:[~2024-03-12  7:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  9:48 Sergey Bronnikov via Tarantool-patches
2023-10-24 13:41 ` Maxim Kokryashkin via Tarantool-patches
2023-10-31 10:42   ` Sergey Bronnikov via Tarantool-patches
2023-10-31 19:17 ` Igor Munkin via Tarantool-patches
2023-11-11 17:05   ` Sergey Bronnikov via Tarantool-patches
2023-11-16 16:15     ` Maxim Kokryashkin via Tarantool-patches
2024-03-10 20:03 ` Igor Munkin via Tarantool-patches
2024-03-12  7:09   ` Sergey Bronnikov via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb811f2c-4c9b-49ee-af07-3d16d4ca5014@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=imun@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit][v2] cmake: replace prove with CTest' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox