From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>,
Sergey Kaplun <skaplun@tarantool.org>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit][v2] cmake: replace prove with CTest
Date: Sun, 10 Mar 2024 20:03:39 +0000 [thread overview]
Message-ID: <Ze4SG_i0yRhmmUdk@tarantool.org> (raw)
In-Reply-To: <9b4befc22674bcc924ad74313d968d1748b85bd9.1698053812.git.sergeyb@tarantool.org>
Sergey,
I've pushed the new version[1], tweaked and rebased onto the bleeding
master, with a tiny fixup for LuaJIT tests series on the top of the
branch (I left no comments, but the fix relates to Sergey adventures
with CMake lists). Unfortunately, I automatically squashed all the
tweaks made to the original commit, but I hope it's not a problem.
Besides, there are still some issues with the new LuaJIT C tests being
run with the sanitizers. I hope Sergey will help you to figure out
what's going wrong.
When all the issues are resoluved, please send the new version of the
patch to the ml, to get all the required LGTMs.
[1]: https://github.com/tarantool/luajit/commit/7d71534
--
Best regards,
IM
next prev parent reply other threads:[~2024-03-10 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 9:48 Sergey Bronnikov via Tarantool-patches
2023-10-24 13:41 ` Maxim Kokryashkin via Tarantool-patches
2023-10-31 10:42 ` Sergey Bronnikov via Tarantool-patches
2023-10-31 19:17 ` Igor Munkin via Tarantool-patches
2023-11-11 17:05 ` Sergey Bronnikov via Tarantool-patches
2023-11-16 16:15 ` Maxim Kokryashkin via Tarantool-patches
2024-03-10 20:03 ` Igor Munkin via Tarantool-patches [this message]
2024-03-12 7:09 ` Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ze4SG_i0yRhmmUdk@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit][v2] cmake: replace prove with CTest' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox