Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: make DROP TABLE delete entry from _sequence_data
Date: Mon, 15 Oct 2018 21:54:42 +0300	[thread overview]
Message-ID: <bb7d9562-e840-bdf8-aede-40d1d2ebfab0@tarantool.org> (raw)
In-Reply-To: <20181015183615.28548-1-korablev@tarantool.org>

Hi! Thanks for the patch!

> diff --git a/test/sql/drop-table.result b/test/sql/drop-table.result
> index 08f249668..bf02e3def 100644
> --- a/test/sql/drop-table.result
> +++ b/test/sql/drop-table.result
> @@ -29,6 +29,23 @@ box.sql.execute("INSERT INTO zzzoobar VALUES (111, 222, 'c3', 444)")
>   ---
>   - error: 'no such table: ZZZOOBAR'
>   ...
> +-- gh-3712: if space features sequence, data from _sequence_data
> +-- must be deleted before space is dropped.
> +--
> +box.sql.execute("CREATE TABLE t1 (id INT PRIMARY KEY AUTOINCREMENT);")
> +---
> +...
> +box.sql.execute("INSERT INTO t1 VALUES (NULL);")
> +---
> +...
> +box.snapshot()
> +---
> +- ok
> +...
> +test_run:cmd('restart server default')

Unfortunately, we have no luxury of time to restart a
server on such a simple test. Lets just check that
_sequence_data space is empty.

> +box.sql.execute("DROP TABLE t1;")
> +---
> +...
>   -- Cleanup
>   -- DROP TABLE should do the job
>   -- Debug

  reply	other threads:[~2018-10-15 18:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15 18:36 [tarantool-patches] " Nikita Pettik
2018-10-15 18:54 ` Vladislav Shpilevoy [this message]
2018-10-15 19:04   ` [tarantool-patches] " n.pettik
2018-10-15 19:42     ` Vladislav Shpilevoy
2018-11-01 14:55   ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb7d9562-e840-bdf8-aede-40d1d2ebfab0@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: make DROP TABLE delete entry from _sequence_data' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox