From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] console: drop unused serpent module
Date: Thu, 19 Nov 2020 14:55:14 +0300 [thread overview]
Message-ID: <bb5bc12e-cf27-b441-2794-63f53e97e6d3@tarantool.org> (raw)
In-Reply-To: <20201113145648.268768-1-gorcunov@gmail.com>
Hi, Cyrill!
thanks for the patch! I propose to get rid of exclude for serpent in
.luacheckrc too.
On 13.11.2020 17:56, Cyrill Gorcunov wrote:
> Since the commit ae7e210 we use internal serializer
> thus we no longer need serpent code.
>
> The patch removes the references from the source code
> and .gitmodules file, still one might need to run
>
> | git submodule deinit -f third_party/serpent
>
> manually to clean up the working tree depending
> on local git version.
>
> Closes #5517
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
next prev parent reply other threads:[~2020-11-19 11:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:56 Cyrill Gorcunov
2020-11-19 11:55 ` Sergey Bronnikov [this message]
2020-11-19 12:05 ` Cyrill Gorcunov
2020-11-19 20:52 ` Cyrill Gorcunov
2020-11-25 9:27 ` Sergey Bronnikov
2020-12-01 9:29 ` Alexander V. Tikhonov
2020-12-01 12:20 ` Alexander Turenko
2020-12-01 12:22 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb5bc12e-cf27-b441-2794-63f53e97e6d3@tarantool.org \
--to=sergeyb@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] console: drop unused serpent module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox