From: Oleg Babin <olegrok@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org,
alexander.turenko@tarantool.org, imun@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup
Date: Sat, 15 Feb 2020 22:02:21 +0300 [thread overview]
Message-ID: <bab4fb0d-bfeb-c617-1918-a2372c3037f6@tarantool.org> (raw)
In-Reply-To: <cover.1581790002.git.v.shpilevoy@tarantool.org>
Hi! Thanks for your patch!
On 15/02/2020 21:08, Vladislav Shpilevoy wrote:
> Branch:
http://github.com/tarantool/tarantool/tree/gerold103/gh-4662-fiber-storage-leak
> Issue: https://github.com/tarantool/tarantool/issues/4662
>
I think you made a mistake and your branch is
https://github.com/tarantool/tarantool/compare/gerold103/gh-4684-tuple-bless-crash
and issue is #4684
Also I've found that "next", "ipairs", "slice" and "upsert" are not
documented as well.
Patches LGTM.
next prev parent reply other threads:[~2020-02-15 19:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 18:08 Vladislav Shpilevoy
2020-02-15 18:08 ` [Tarantool-patches] [PATCH 1/2] tuple: hide internal functions from box.tuple.* Vladislav Shpilevoy
2020-03-16 13:15 ` Nikita Pettik
2020-02-15 18:08 ` [Tarantool-patches] [PATCH 2/2] tuple: make box.tuple.is() public Vladislav Shpilevoy
2020-02-16 15:07 ` Vladislav Shpilevoy
2020-02-17 20:21 ` Oleg Babin
2020-02-17 21:11 ` Vladislav Shpilevoy
2020-03-16 13:19 ` Nikita Pettik
2020-02-15 19:02 ` Oleg Babin [this message]
2020-02-16 15:07 ` [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup Vladislav Shpilevoy
2020-03-01 14:21 ` Igor Munkin
2020-03-15 17:42 ` Vladislav Shpilevoy
2020-03-15 22:38 ` Nikita Pettik
2020-03-16 14:07 ` Kirill Yukhin
2020-03-16 17:48 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bab4fb0d-bfeb-c617-1918-a2372c3037f6@tarantool.org \
--to=olegrok@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox