From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro replication usage reporting
Date: Tue, 13 Oct 2020 17:05:27 +0300 [thread overview]
Message-ID: <ba3261b7-9879-47ae-ac07-ef45aa938718@tarantool.org> (raw)
In-Reply-To: <20201013140155.GE14048@grain>
13.10.2020 17:01, Cyrill Gorcunov пишет:
> On Tue, Oct 13, 2020 at 04:34:18PM +0300, Serge Petrenko wrote:
>>
>> +local function fill_in_options(feedback)
>> + local options = {}
>> + options.election_mode = box.cfg.election_mode
>> + options.synchro_quorum = box.cfg.replication_synchro_quorum
>> + feedback.options = options
>> +end
> Maybe be we could just get rid of local variable here?
Yes, sure. I'll do it together with other fixes, if any.
>
> local function fill_in_options(feedback)
> feedback.options = {
> ['election_mode'] = box.cfg.election_mode,
> ['synchro_quorum'] = box.cfg.replication_synchro_quorum,
> }
> end
>
> Not insisting at all just a thought.
--
Serge Petrenko
next prev parent reply other threads:[~2020-10-13 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 13:34 Serge Petrenko
2020-10-13 13:54 ` Serge Petrenko
2020-10-13 14:01 ` Cyrill Gorcunov
2020-10-13 14:05 ` Serge Petrenko [this message]
2020-10-13 15:56 ` Serge Petrenko
2020-10-14 23:50 ` Vladislav Shpilevoy
2020-10-15 8:30 ` Serge Petrenko
2020-10-15 19:45 ` Vladislav Shpilevoy
2020-10-20 17:09 ` Илья Конюхов
2020-10-20 19:16 ` Serge Petrenko
2020-10-21 8:42 ` Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba3261b7-9879-47ae-ac07-ef45aa938718@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro replication usage reporting' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox