From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: remove usless sqlite3NestedParse function
Date: Thu, 5 Jul 2018 19:11:37 +0300 [thread overview]
Message-ID: <ba17d5bc-2812-bd9d-433e-3dbaa4527c5f@tarantool.org> (raw)
In-Reply-To: <444b91093cc6ea1648f0e8bdd9b0923694ca3f8a.1530724375.git.kshcherbatov@tarantool.org>
Thanks for the patch!
Please, finish it. You did not remove Parse.nested and
PARSE_TAIL. And maybe something else.
On 04/07/2018 20:17, Kirill Shcherbatov wrote:
> As sqlite3NestedParse become totaly useless, let's
> remove unreacheble code and all mentioning.
>
> Resolves #3496.
> ---
> src/box/sql/build.c | 40 ----------------------------------------
> src/box/sql/delete.c | 6 +-----
> src/box/sql/insert.c | 6 +-----
> src/box/sql/sqliteInt.h | 1 -
> src/box/sql/update.c | 6 +-----
> 5 files changed, 3 insertions(+), 56 deletions(-)
>
next prev parent reply other threads:[~2018-07-05 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 17:17 [tarantool-patches] [PATCH v1 0/2] sql: get rid off sqlite3NestedParse Kirill Shcherbatov
2018-07-04 17:17 ` [tarantool-patches] [PATCH v1 1/2] sql: get rid off sqlite3NestedParse in clean stats Kirill Shcherbatov
2018-07-05 16:11 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-06 18:13 ` Kirill Shcherbatov
2018-07-09 10:20 ` Vladislav Shpilevoy
2018-07-04 17:17 ` [tarantool-patches] [PATCH v1 2/2] sql: remove usless sqlite3NestedParse function Kirill Shcherbatov
2018-07-05 16:11 ` Vladislav Shpilevoy [this message]
2018-07-06 18:13 ` [tarantool-patches] " Kirill Shcherbatov
2018-07-09 10:20 ` [tarantool-patches] Re: [PATCH v1 0/2] sql: get rid off sqlite3NestedParse Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba17d5bc-2812-bd9d-433e-3dbaa4527c5f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 2/2] sql: remove usless sqlite3NestedParse function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox