From: Kirill Yukhin <kyukhin@tarantool.org> To: vdavydov.dev@gmail.com Cc: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org> Subject: [PATCH v2 2/4] Set is_temporary flag for formats of ephemeral spaces Date: Thu, 24 Jan 2019 15:48:46 +0300 [thread overview] Message-ID: <b9fda4a9ce89b2f2773a648127e26e808ff40821.1548333874.git.kyukhin@tarantool.org> (raw) In-Reply-To: <cover.1548333874.git.kyukhin@tarantool.org> Before the patch, when ephemeral space was created flag is_temporary was set after space was actually created. Which in turn lead to corresponding flag of tuple_format being set to `false`. So, having heavy load using ephemeral spaces (almost any SQL query) and snapshotting at the same time might lead to OOM, since tuples of ephemeral spaces were not marked as temporary and were not gc-ed. Patch sets the flag in space definition. --- src/box/space.c | 2 +- src/box/space_def.c | 14 ++++++++++++++ src/box/space_def.h | 9 +++++++++ src/box/sql.c | 6 +----- 4 files changed, 25 insertions(+), 6 deletions(-) diff --git a/src/box/space.c b/src/box/space.c index 4d174f7..6245167 100644 --- a/src/box/space.c +++ b/src/box/space.c @@ -194,10 +194,10 @@ space_new(struct space_def *def, struct rlist *key_list) struct space * space_new_ephemeral(struct space_def *def, struct rlist *key_list) { + assert(def->opts.is_temporary); struct space *space = space_new(def, key_list); if (space == NULL) return NULL; - space->def->opts.is_temporary = true; space->vtab->init_ephemeral_space(space); return space; } diff --git a/src/box/space_def.c b/src/box/space_def.c index 3516bdd..d60c2d3 100644 --- a/src/box/space_def.c +++ b/src/box/space_def.c @@ -257,6 +257,20 @@ space_def_new(uint32_t id, uint32_t uid, uint32_t exact_field_count, return def; } +struct space_def* +space_def_new_ephemeral(uint32_t field_count) +{ + struct space_opts opts = space_opts_default; + opts.is_temporary = true; + struct space_def *space_def = space_def_new(0, 0, field_count, + "ephemeral", + strlen("ephemeral"), + "memtx", strlen("memtx"), + &opts, &field_def_default, + 0); + return space_def; +} + /** Free a default value's syntax trees of @a defs. */ void space_def_destroy_fields(struct field_def *fields, uint32_t field_count, diff --git a/src/box/space_def.h b/src/box/space_def.h index 8044f88..b6ab6b3 100644 --- a/src/box/space_def.h +++ b/src/box/space_def.h @@ -169,6 +169,15 @@ space_def_new(uint32_t id, uint32_t uid, uint32_t exact_field_count, const struct space_opts *opts, const struct field_def *fields, uint32_t field_count); +/** + * Create a new ephemeral space definition. + * @param field_count Number of fields in the space. + * + * @retval Space definition. + */ +struct space_def * +space_def_new_ephemeral(uint32_t field_count); + /** * Size of the space_def. * @param name_len Length of the space name. diff --git a/src/box/sql.c b/src/box/sql.c index 081a038..387da7b 100644 --- a/src/box/sql.c +++ b/src/box/sql.c @@ -408,11 +408,7 @@ sql_ephemeral_space_create(uint32_t field_count, struct sql_key_info *key_info) rlist_add_entry(&key_list, ephemer_index_def, link); struct space_def *ephemer_space_def = - space_def_new(0 /* space id */, 0 /* user id */, field_count, - "ephemeral", strlen("ephemeral"), - "memtx", strlen("memtx"), - &space_opts_default, &field_def_default, - 0 /* length of field_def */); + space_def_new_ephemeral(field_count); if (ephemer_space_def == NULL) { index_def_delete(ephemer_index_def); return NULL; -- 2.19.1
next prev parent reply other threads:[~2019-01-24 12:48 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-24 12:48 [PATCH v2 0/4] Reuse tuple formats for " Kirill Yukhin 2019-01-24 12:48 ` [PATCH v2 1/4] Pass necessary fields to tuple_format contructor Kirill Yukhin 2019-01-24 17:26 ` Vladimir Davydov 2019-01-24 12:48 ` Kirill Yukhin [this message] 2019-01-24 17:26 ` [PATCH v2 2/4] Set is_temporary flag for formats of ephemeral spaces Vladimir Davydov 2019-01-24 12:48 ` [PATCH v2 3/4] sql: set error type in case of ephemral space creation failure Kirill Yukhin 2019-01-24 17:26 ` Vladimir Davydov 2019-01-24 12:48 ` [PATCH v2 4/4] Allow to reuse tuple_formats for ephemeral spaces Kirill Yukhin 2019-01-24 17:49 ` Vladimir Davydov 2019-01-25 6:05 ` Kirill Yukhin 2019-01-25 9:01 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b9fda4a9ce89b2f2773a648127e26e808ff40821.1548333874.git.kyukhin@tarantool.org \ --to=kyukhin@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH v2 2/4] Set is_temporary flag for formats of ephemeral spaces' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox