From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: tarantool-patches@freelists.org
Subject: [PATCH 1/2] test: fix vinyl/errinj_stat again
Date: Thu, 11 Apr 2019 13:13:37 +0300 [thread overview]
Message-ID: <b9a05d098da3f6fd64e2fe64bdcbfee6d0df0438.1554977592.git.vdavydov.dev@gmail.com> (raw)
Another failure this time:
| [024] —- vinyl/errinj_stat.result Wed Apr 10 14:21:34 2019
| [024] +++ vinyl/errinj_stat.reject Wed Apr 10 14:24:15 2019
| [024] @@ -220,7 +220,7 @@
| [024] ...
| [024] box.snapshot()
| [024] —-
| [024] — error: Error injection 'vinyl dump'
| [024] +- error: Snapshot is already in progress
| [024] ...
| [024] stat = box.stat.vinyl().scheduler
| [024] —-
| [024] @@ -231,7 +231,7 @@
| [024] ...
| [024] stat.tasks_failed > 0
| [024] —-
| [024] — true
| [024] +- false
| [024] ...
| [024] errinj.set('ERRINJ_VY_RUN_WRITE', false)
| [024] —-
Hope it's the last time we fix it.
Follow-up commit f4b80bcf4908 ("test: fix vinyl/errinj_stat failure").
---
test/vinyl/errinj_stat.result | 8 ++++++++
test/vinyl/errinj_stat.test.lua | 2 ++
2 files changed, 10 insertions(+)
diff --git a/test/vinyl/errinj_stat.result b/test/vinyl/errinj_stat.result
index a4e63357..f1133137 100644
--- a/test/vinyl/errinj_stat.result
+++ b/test/vinyl/errinj_stat.result
@@ -191,6 +191,10 @@ test_run:wait_cond(function() return box.stat.vinyl().scheduler.tasks_completed
---
- true
...
+test_run:wait_cond(function() return not box.info.gc().checkpoint_is_in_progress end)
+---
+- true
+...
stat = box.stat.vinyl().scheduler
---
...
@@ -325,6 +329,10 @@ test_run:wait_cond(function() return box.stat.vinyl().scheduler.tasks_completed
---
- true
...
+test_run:wait_cond(function() return not box.info.gc().checkpoint_is_in_progress end)
+---
+- true
+...
i:stat().disk.dump.time >= 0.1
---
- true
diff --git a/test/vinyl/errinj_stat.test.lua b/test/vinyl/errinj_stat.test.lua
index c3000bba..d11da450 100644
--- a/test/vinyl/errinj_stat.test.lua
+++ b/test/vinyl/errinj_stat.test.lua
@@ -60,6 +60,7 @@ box.stat.reset() -- doesn't affect tasks_inprogress
box.stat.vinyl().scheduler.tasks_inprogress > 0
errinj.set('ERRINJ_VY_RUN_WRITE_DELAY', false)
test_run:wait_cond(function() return box.stat.vinyl().scheduler.tasks_completed > 0 end)
+test_run:wait_cond(function() return not box.info.gc().checkpoint_is_in_progress end)
stat = box.stat.vinyl().scheduler
stat.tasks_inprogress == 0
stat.tasks_completed == 1
@@ -101,6 +102,7 @@ test_run:wait_cond(function() return box.stat.vinyl().scheduler.tasks_inprogress
fiber.sleep(0.1)
errinj.set('ERRINJ_VY_RUN_WRITE_DELAY', false)
test_run:wait_cond(function() return box.stat.vinyl().scheduler.tasks_completed > 0 end)
+test_run:wait_cond(function() return not box.info.gc().checkpoint_is_in_progress end)
i:stat().disk.dump.time >= 0.1
i:stat().disk.dump.time <= fiber.time() - start_time
i:stat().disk.compaction.time == 0
--
2.11.0
next reply other threads:[~2019-04-11 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 10:13 Vladimir Davydov [this message]
2019-04-11 10:13 ` [PATCH 2/2] test: fix vinyl/errinj_ddl failure Vladimir Davydov
2019-04-11 10:14 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a05d098da3f6fd64e2fe64bdcbfee6d0df0438.1554977592.git.vdavydov.dev@gmail.com \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 1/2] test: fix vinyl/errinj_stat again' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox