Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
	tarantool-patches@freelists.org,
	Kirill Yukhin <kyukhin@tarantool.org>,
	Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v4 8/8] sql: remove global sql_trigger hash
Date: Fri, 29 Jun 2018 16:31:09 +0300	[thread overview]
Message-ID: <b8da016f-7932-8812-abd2-a6c2c4a8c8f8@tarantool.org> (raw)
In-Reply-To: <aae1921f-f153-80bb-d563-e02fcb8a25ad@tarantool.org>



On 29/06/2018 16:28, Kirill Shcherbatov wrote:
>> Hello. Thanks for the patch! I have pushed my review fixes
>> as a separate commit for this patch and for
>> "sql: refactor trigger API functions".
> Hello! Thank you for fixes!
> I've spitted them and merged into appropriate commits.

Then LGTM. Now I think it is time to merge the whole
triggers patchset.

> 
> Do we ready for merge it?
> 

  reply	other threads:[~2018-06-29 13:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1530029141.git.kshcherbatov@tarantool.org>
2018-06-26 16:13 ` [tarantool-patches] [PATCH v4 6/8] sql: refactor AST trigger object name Kirill Shcherbatov
2018-06-27 15:57   ` [tarantool-patches] " n.pettik
2018-06-27 16:35     ` Kirill Shcherbatov
2018-06-27 17:41       ` n.pettik
2018-06-27 18:04         ` Kirill Shcherbatov
2018-06-26 16:13 ` [tarantool-patches] [PATCH v4 8/8] sql: remove global sql_trigger hash Kirill Shcherbatov
2018-06-27 17:28   ` [tarantool-patches] " n.pettik
2018-06-27 18:04     ` Kirill Shcherbatov
2018-06-28 19:17       ` Vladislav Shpilevoy
2018-06-29 13:28         ` Kirill Shcherbatov
2018-06-29 13:31           ` Vladislav Shpilevoy [this message]
2018-06-29 13:54             ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8da016f-7932-8812-abd2-a6c2c4a8c8f8@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v4 8/8] sql: remove global sql_trigger hash' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox