From: Oleg Babin <olegrok@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/7] box/console: console_session_vtab -- use designated initialization
Date: Mon, 18 May 2020 15:03:54 +0300 [thread overview]
Message-ID: <b8d83f41-31b4-0ab3-0850-7f6bd9ce8fdf@tarantool.org> (raw)
In-Reply-To: <20200512135052.221379-2-gorcunov@gmail.com>
Hi! Thanks for your patch. LGTM.
On 12/05/2020 16:50, Cyrill Gorcunov wrote:
> For better maintainance.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> src/box/lua/console.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/box/lua/console.c b/src/box/lua/console.c
> index b941f50c6..d937d684e 100644
> --- a/src/box/lua/console.c
> +++ b/src/box/lua/console.c
> @@ -582,9 +582,9 @@ tarantool_lua_console_init(struct lua_State *L)
> */
> lua_setfield(L, -2, "formatter");
> struct session_vtab console_session_vtab = {
> - /* .push = */ console_session_push,
> - /* .fd = */ console_session_fd,
> - /* .sync = */ generic_session_sync,
> + .push = console_session_push,
> + .fd = console_session_fd,
> + .sync = generic_session_sync,
> };
> session_vtab_registry[SESSION_TYPE_CONSOLE] = console_session_vtab;
> session_vtab_registry[SESSION_TYPE_REPL] = console_session_vtab;
>
next prev parent reply other threads:[~2020-05-18 12:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 13:50 [Tarantool-patches] [PATCH 0/7] box/console: add support for internal types Cyrill Gorcunov
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 1/7] box/console: console_session_vtab -- use designated initialization Cyrill Gorcunov
2020-05-18 12:03 ` Oleg Babin [this message]
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 2/7] box/console: use tabs instead of spaces in consolelib Cyrill Gorcunov
2020-05-18 12:04 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 3/7] box/console: rename format to format_yaml Cyrill Gorcunov
2020-05-18 12:04 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 4/7] box/console: rename luaL_yaml_default to serializer_yaml Cyrill Gorcunov
2020-05-18 12:11 ` Oleg Babin
2020-05-18 21:17 ` Igor Munkin
2020-05-19 6:47 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 5/7] box/console: implement lua serializer Cyrill Gorcunov
2020-05-18 12:18 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 6/7] box/console: switch to new " Cyrill Gorcunov
2020-05-18 12:21 ` Oleg Babin
2020-05-12 13:50 ` [Tarantool-patches] [PATCH 7/7] test: extend console lua test Cyrill Gorcunov
2020-05-18 12:22 ` Oleg Babin
2020-05-18 12:25 ` Cyrill Gorcunov
2020-05-18 12:46 ` [Tarantool-patches] [PATCH 0/7] box/console: add support for internal types Kirill Yukhin
-- strict thread matches above, loose matches on Subject: below --
2020-05-08 11:47 Cyrill Gorcunov
2020-05-08 11:47 ` [Tarantool-patches] [PATCH 1/7] box/console: console_session_vtab -- use designated initialization Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8d83f41-31b4-0ab3-0850-7f6bd9ce8fdf@tarantool.org \
--to=olegrok@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/7] box/console: console_session_vtab -- use designated initialization' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox