From: Alexander Turenko <alexander.turenko@tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 11/13] coio: fix obsoleted comment in coio_write_timeout Date: Fri, 10 Apr 2020 05:50:49 +0300 [thread overview] Message-ID: <b8a6ac04567bfca470f88c8d45ce3038bddf4baa.1586486220.git.alexander.turenko@tarantool.org> (raw) In-Reply-To: <cover.1586486219.git.alexander.turenko@tarantool.org> The comment was added in 52765de65b8304424ef3d7014952f9fa55ee46f4, but becomes non-actual since 1.6.6-21-gc74abc786 ('Implement special TimedOut exception type and use it in coio and latch.') Part of #4031 --- src/lib/core/coio.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/core/coio.cc b/src/lib/core/coio.cc index e88d724d5..74e6240ce 100644 --- a/src/lib/core/coio.cc +++ b/src/lib/core/coio.cc @@ -388,8 +388,8 @@ coio_readn_ahead_timeout(struct ev_io *coio, void *buf, size_t sz, size_t bufsiz * fiber until the socket becomes ready, until * all data is written. * - * @retval the number of bytes written. Can be less than - * requested only in case of timeout. + * @retval the number of bytes written. Always + * equal to @a sz. */ ssize_t coio_write_timeout(struct ev_io *coio, const void *buf, size_t sz, -- 2.25.0
next prev parent reply other threads:[~2020-04-10 2:51 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-10 2:50 [Tarantool-patches] [PATCH 00/13] Popen Lua API: preliminary patches Alexander Turenko 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 01/13] popen: require popen handle to be non-NULL Alexander Turenko 2020-04-10 7:16 ` Cyrill Gorcunov 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 02/13] popen: remove retval from popen_state() Alexander Turenko 2020-04-10 7:17 ` Cyrill Gorcunov 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 03/13] popen: add missed diag_set in popen_signal/delete Alexander Turenko 2020-04-10 7:23 ` Cyrill Gorcunov 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 04/13] popen: add logging of fds closed in a child Alexander Turenko 2020-04-10 7:46 ` Cyrill Gorcunov 2020-04-10 12:19 ` Alexander Turenko 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 05/13] say: allow to set a logger file descriptor Alexander Turenko 2020-04-10 8:33 ` Cyrill Gorcunov 2020-04-10 12:19 ` Alexander Turenko 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 06/13] popen: decouple logger fd from stderr Alexander Turenko 2020-04-10 9:18 ` Cyrill Gorcunov 2020-04-10 12:20 ` Alexander Turenko 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 07/13] popen: add const qualifier to popen_write_timeout Alexander Turenko 2020-04-10 8:04 ` Cyrill Gorcunov 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 08/13] popen: unblock popen_read_timeout at a first byte Alexander Turenko 2020-04-10 8:10 ` Cyrill Gorcunov 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 09/13] popen: remove redundant fd check before perform IO Alexander Turenko 2020-04-10 8:18 ` Cyrill Gorcunov 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 10/13] popen: add missed diag_set() in popen IO functions Alexander Turenko 2020-04-10 8:28 ` Cyrill Gorcunov 2020-04-10 2:50 ` Alexander Turenko [this message] 2020-04-10 8:28 ` [Tarantool-patches] [PATCH 11/13] coio: fix obsoleted comment in coio_write_timeout Cyrill Gorcunov 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 12/13] coio: add *_noxc read / write functions Alexander Turenko 2020-04-10 8:05 ` Konstantin Osipov 2020-04-10 8:17 ` Cyrill Gorcunov 2020-04-10 11:57 ` Alexander Turenko 2020-04-12 12:51 ` Alexander Turenko 2020-04-10 8:29 ` Cyrill Gorcunov 2020-04-10 2:50 ` [Tarantool-patches] [PATCH 13/13] popen: use of exception safe functions for IO Alexander Turenko 2020-04-10 11:50 ` Cyrill Gorcunov 2020-04-10 12:21 ` Alexander Turenko 2020-04-10 16:36 ` [Tarantool-patches] [PATCH 00/13] Popen Lua API: preliminary patches Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b8a6ac04567bfca470f88c8d45ce3038bddf4baa.1586486220.git.alexander.turenko@tarantool.org \ --to=alexander.turenko@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 11/13] coio: fix obsoleted comment in coio_write_timeout' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox