Re: [Tarantool-patches] [PATCH 0/5] mp_snprint() and mp_fprint() for decimal, uuid, error

[Serge Petrenko <sergepetrenko@tarantool.org>]

Hi! Thanks for the patchset!

12.05.2020 02:45, Vladislav Shpilevoy пишет:
> The patchset makes msgpuck functions mp_snprint() and mp_fprint()
> nicely serialize MP_DECIMAL, MP_UUID, and MP_ERROR objects.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4719-mp_print-ext
> Issue: https://github.com/tarantool/tarantool/issues/4719
>
> Vladislav Shpilevoy (5):
>    msgpuck: bump version to enable extension printer
>    decimal: provide MP_DECIMAL extension serializer
>    uuid: provide MP_UUID extension serializer
>    error: provide MP_ERROR extension serializer
>    msgpuck: activate MP_EXT custom serializers
>
>   src/box/CMakeLists.txt    |   1 +
>   src/box/box.cc            |   2 +
>   src/box/mp_error.cc       | 161 ++++++++++++++++++++++-
>   src/box/mp_error.h        |  29 ++++
>   src/box/msgpack.c         |  78 +++++++++++
>   src/box/msgpack.h         |  41 ++++++
>   src/lib/core/mp_decimal.c |  18 +++
>   src/lib/core/mp_decimal.h |  27 ++++
>   src/lib/msgpuck           |   2 +-
>   src/lib/uuid/mp_uuid.c    |  18 +++
>   src/lib/uuid/mp_uuid.h    |  27 ++++
>   test/unit/decimal.c       |  63 ++++++++-
>   test/unit/decimal.result  |  11 +-
>   test/unit/mp_error.cc     | 270 +++++++++++++++++++++++++++++++++++++-
>   test/unit/mp_error.result |  72 +++++++++-
>   test/unit/msgpack.result  |  17 ++-
>   test/unit/uuid.c          |  64 ++++++++-
>   test/unit/uuid.result     |  11 +-
>   18 files changed, 900 insertions(+), 12 deletions(-)
>   create mode 100644 src/box/msgpack.c
>   create mode 100644 src/box/msgpack.h

LGTM

-- 
Serge Petrenko