[tarantool-patches] [PATCH v1 1/1] box: do not check state in case of reconnect

[tarantool-patches] [PATCH v1 1/1] box: do not check state in case of reconnect

[imeevma]

Test box/net.box.test.lua checks state of the connection in case
of an error. It should be 'error_reconnect'. But, in cases where
testing was performed on a slow computer or in the case of a very
large load, it is possible that the connection status may change
from the 'error_reconnect' state to another state. This led to the
failure of the test. Since this check is not the main purpose of
the test, it is better to simply delete the check.

Closes #4335
---
https://github.com/tarantool/tarantool/issues/4335
https://github.com/tarantool/tarantool/tree/imeevma/gh-4335-reconnect-state-error

 test/box/net.box.result   | 4 ----
 test/box/net.box.test.lua | 1 -
 2 files changed, 5 deletions(-)

diff --git a/test/box/net.box.result b/test/box/net.box.result
index a18546d..92b6a2c 100644
--- a/test/box/net.box.result
+++ b/test/box/net.box.result
@@ -2818,10 +2818,6 @@ c.space.test:delete{1}
 _ = c._transport.perform_request(nil, nil, false, 'inject', nil, nil, nil, '\x80')
 ---
 ...
-c.state
----
-- error_reconnect
-...
 while not c:is_connected() do fiber.sleep(0.01) end
 ---
 ...
diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua
index 07558a0..e213d9a 100644
--- a/test/box/net.box.test.lua
+++ b/test/box/net.box.test.lua
@@ -1156,7 +1156,6 @@ c.space.test:delete{1}
 -- Break a connection to test reconnect_after.
 --
 _ = c._transport.perform_request(nil, nil, false, 'inject', nil, nil, nil, '\x80')
-c.state
 while not c:is_connected() do fiber.sleep(0.01) end
 c:ping()
 
-- 
2.7.4

[tarantool-patches] Re: [PATCH v1 1/1] box: do not check state in case of reconnect

[Vladislav Shpilevoy]

Hi! Thanks for the patch!

LGTM.

[tarantool-patches] Re: [PATCH v1 1/1] box: do not check state in case of reconnect

[Kirill Yukhin]

Hello,

On 11 Jul 17:12, imeevma@tarantool.org wrote:
> Test box/net.box.test.lua checks state of the connection in case
> of an error. It should be 'error_reconnect'. But, in cases where
> testing was performed on a slow computer or in the case of a very
> large load, it is possible that the connection status may change
> from the 'error_reconnect' state to another state. This led to the
> failure of the test. Since this check is not the main purpose of
> the test, it is better to simply delete the check.
> 
> Closes #4335
> ---
> https://github.com/tarantool/tarantool/issues/4335
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4335-reconnect-state-error

I've checked the patch into master.

--
Regards, Kirill Yukhin