From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org
Cc: "v.shpilevoy@tarantool.org" <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 06/11] sql: refactor sql_expr_compile to return AST
Date: Thu, 14 Jun 2018 19:12:44 +0300 [thread overview]
Message-ID: <b71e7bf6-78bf-4323-d3f8-ea6857e5fed7@tarantool.org> (raw)
In-Reply-To: <01231fae-68d6-f6c3-5ead-8df59efae4cf@tarantool.org>
> Why not just diag_set(ClientError, ER_SQL, sql_error); ?
+ char *sql_error;
+ if (sqlite3RunParser(&parser, stmt, &sql_error) != SQLITE_OK &&
+ parser.rc != SQL_TARANTOOL_ERROR)
+ diag_set(ClientError, ER_SQL, sql_error);
+ else
+ expression = parser.parsed_expr;
next prev parent reply other threads:[~2018-06-14 16:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-09 9:58 [tarantool-patches] [PATCH v2 00/11] sql: remove Triggers to server Kirill Shcherbatov
2018-06-09 9:32 ` [tarantool-patches] [PATCH v2 10/11] sql: move " Kirill Shcherbatov
2018-06-13 18:53 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 16:12 ` Kirill Shcherbatov
2018-06-28 7:18 ` Konstantin Osipov
2018-06-28 7:33 ` Kirill Shcherbatov
2018-06-09 9:32 ` [tarantool-patches] [PATCH v2 11/11] sql: VDBE tests for trigger existence Kirill Shcherbatov
2018-06-13 18:53 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 16:12 ` Kirill Shcherbatov
2018-06-09 9:32 ` [tarantool-patches] [PATCH v2 02/11] box: move db->pShchema init to sql_init Kirill Shcherbatov
2018-06-09 9:32 ` [tarantool-patches] [PATCH v2 04/11] sql: fix sql len in tarantoolSqlite3RenameTrigger Kirill Shcherbatov
2018-06-09 9:32 ` [tarantool-patches] [PATCH v2 06/11] sql: refactor sql_expr_compile to return AST Kirill Shcherbatov
2018-06-13 18:53 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 16:12 ` Kirill Shcherbatov [this message]
2018-06-09 9:32 ` [tarantool-patches] [PATCH v2 07/11] sql: move sqlite3DeleteTrigger to sql.h Kirill Shcherbatov
2018-06-13 18:53 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 16:12 ` Kirill Shcherbatov
2018-06-09 9:32 ` [tarantool-patches] [PATCH v2 08/11] box: sort error codes in misc.test Kirill Shcherbatov
2018-06-09 9:32 ` [tarantool-patches] [PATCH v2 09/11] sql: new _trigger space format with space_id Kirill Shcherbatov
2018-06-13 18:53 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 16:12 ` Kirill Shcherbatov
2018-06-09 9:58 ` [tarantool-patches] [PATCH v2 01/11] box: remove migration from alpha 1.8.2 and 1.8.4 Kirill Shcherbatov
2018-06-09 9:58 ` [tarantool-patches] [PATCH v2 03/11] sql: fix leak on CREATE TABLE and resolve self ref Kirill Shcherbatov
2018-06-13 18:53 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 16:12 ` Kirill Shcherbatov
2018-06-09 9:58 ` [tarantool-patches] [PATCH v2 05/11] box: port schema_find_id to C Kirill Shcherbatov
2018-06-13 18:53 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 16:12 ` Kirill Shcherbatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b71e7bf6-78bf-4323-d3f8-ea6857e5fed7@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v2 06/11] sql: refactor sql_expr_compile to return AST' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox