Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/4] Don't truncate float in update
Date: Thu, 20 Feb 2020 21:30:50 +0100	[thread overview]
Message-ID: <b65e05b2-9506-37b2-061e-97684ce8f0c8@tarantool.org> (raw)
In-Reply-To: <20200220061505.kzbzgcgyjx6b4nkp@tarantool.org>

Hi!

Why did you decide not to push it into 2.2 and 1.10? This is
a bug, and it exists in these versions too.

On 20/02/2020 07:15, Kirill Yukhin wrote:
> Hello,
> 
> On 04 фев 23:53, Vladislav Shpilevoy wrote:
>> The patchset fixes float value truncation in
>> tuple/space:update/upsert. First commit fixes the actual issue,
>> but introduces another bug that a float value can be stored into a
>> field having double type in its format.
>>
>> The rest 3 commits fix this new bug.
>>
>> However, there is an alternative how these 3 could be done. My
>> solution is that I calculate the result types in
>> xrow_update_*_store() functions. Because of that I don't know the
>> types during xrow_update_*_sizeof(), and it needs to return the
>> maximal possible size instead of exact size. The alternative is to
>> calculate types during sizeof. It would allow to return the exact
>> size. But it also would complicate the code. I can implement this
>> option if it looks better.
>>
>> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4701-update-float-truncate
>> Issue: https://github.com/tarantool/tarantool/issues/4701
> 
> LGTM. I've checked your patchset into 2.3 and master.
> 
> --
> Regards, Kirill Yukhin
> 

      parent reply	other threads:[~2020-02-20 20:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 22:53 Vladislav Shpilevoy
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 1/4] tuple: don't truncate float in :update() Vladislav Shpilevoy
2020-02-10 14:41   ` Nikita Pettik
2020-02-10 21:18     ` Vladislav Shpilevoy
2020-02-19 21:36       ` Nikita Pettik
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 2/4] tuple: pass tuple format to xrow_update_*_store() Vladislav Shpilevoy
2020-02-10 16:51   ` Nikita Pettik
2020-02-10 21:18     ` Vladislav Shpilevoy
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 3/4] tuple: allow xrow_update sizeof reserve more memory Vladislav Shpilevoy
2020-02-10 16:05   ` Nikita Pettik
2020-02-04 22:53 ` [Tarantool-patches] [PATCH v2 4/4] tuple: use field type in update of a float/double Vladislav Shpilevoy
2020-02-10 16:16   ` Nikita Pettik
2020-02-10 21:18     ` Vladislav Shpilevoy
2020-02-05 11:09 ` [Tarantool-patches] [PATCH v2 0/4] Don't truncate float in update Konstantin Osipov
2020-02-05 22:11   ` Vladislav Shpilevoy
2020-02-20  6:15 ` Kirill Yukhin
2020-02-20 13:27   ` Nikita Pettik
2020-02-20 20:30   ` Vladislav Shpilevoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b65e05b2-9506-37b2-061e-97684ce8f0c8@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/4] Don'\''t truncate float in update' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox