Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, "Мерген Имеев" <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/1] sql: IS is only applicable when dealing with NULL
Date: Wed, 16 May 2018 21:52:58 +0300	[thread overview]
Message-ID: <b558d70e-4e45-b5bd-5b2d-b1faf9b207ba@tarantool.org> (raw)
In-Reply-To: <1526478655.299515943@f491.i.mail.ru>

Hello. Thanks for the patch! See my 2 comments below.

On 16/05/2018 16:50, Мерген Имеев wrote:
> According to ANSI Standard IS/IS NOT can be used to determine
> if values is null. At the same time in SQLite3 IS/IS NOT have an
> additional function - it can be used to check equality of two
> values. This patch removes that additional function.
> 
> Closes #2136
> ---

1. Please, post here link to the branch and issue like this:
https://www.freelists.org/post/tarantool-patches/PATCH-11-vinyl-fix-crash-in-vinyl-iterator-secondary-next

2. You forgot to push you patch. I do not see a branch on github.

  reply	other threads:[~2018-05-16 18:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 13:50 [tarantool-patches] " Мерген Имеев
2018-05-16 18:52 ` Vladislav Shpilevoy [this message]
2018-05-18 11:26 Мерген Имеев
2018-05-18 11:55 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-18 16:10   ` [tarantool-patches] " Мерген Имеев
2018-05-18 21:37     ` Vladislav Shpilevoy
2018-05-23 14:30       ` Imeev Mergen
2018-05-24 11:52         ` Vladislav Shpilevoy
2018-05-24 14:00           ` Imeev Mergen
2018-05-24 19:46             ` Vladislav Shpilevoy
2018-05-30  8:35               ` Kirill Yukhin
2018-05-18 14:34 ` Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b558d70e-4e45-b5bd-5b2d-b1faf9b207ba@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 1/1] sql: IS is only applicable when dealing with NULL' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox