Re: [Tarantool-patches] [PATCH v4 0/2] Introduce _vsession_settings sysview

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch! LGTM. We need a second
opinion from Nikita.

On 28/11/2019 09:46, imeevma@tarantool.org wrote:
> This patch-set introduces _vsession_settings system view. This
> sysview contains names and current values of the session settings.
> 
> https://github.com/tarantool/tarantool/issues/4511
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4511-system-view-for-session-settings
> 
> Mergen Imeev (2):
>   sysview: make get() and create_iterator() methods virtual
>   box: introduce _vsession_settings sysview
> 
>  src/box/bootstrap.snap             | Bin 5944 -> 5982 bytes
>  src/box/lua/space.cc               |   2 +
>  src/box/lua/upgrade.lua            |  23 ++++++
>  src/box/schema_def.h               |   2 +
>  src/box/session.cc                 | 132 ++++++++++++++++++++++++++++++++++
>  src/box/session.h                  |  13 ++++
>  src/box/sql.h                      |  36 ++++++++++
>  src/box/sql/build.c                | 140 +++++++++++++++++++++++++++++++++++++
>  src/box/sysview.c                  |  48 +++++++++++--
>  test/app-tap/tarantoolctl.test.lua |   4 +-
>  test/box-py/bootstrap.result       |   5 +-
>  test/box/access_sysview.result     | 124 +++++++++++++++++++++++++++++++-
>  test/box/access_sysview.test.lua   |  54 ++++++++++++++
>  test/box/alter.result              |   5 +-
>  test/wal_off/alter.result          |   2 +-
>  15 files changed, 574 insertions(+), 16 deletions(-)
>