From: Serge Petrenko <sergepetrenko@tarantool.org> To: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org, kostja.osipov@gmail.com Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v3 4/4] wal: warn when trying to write a record with a broken lsn Date: Tue, 18 Feb 2020 20:37:07 +0300 [thread overview] Message-ID: <b4c230bcf86545f374b4d97e08793e672a4bcdd4.1582046958.git.sergepetrenko@tarantool.org> (raw) In-Reply-To: <cover.1582046958.git.sergepetrenko@tarantool.org> There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't fire in release builds, of course. Let's at least warn the user on an attemt to write a record with a duplicate or otherwise broken lsn, and not follow such an lsn. Follow-up #4739 --- src/box/wal.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/box/wal.c b/src/box/wal.c index 0ae66ff32..a87aedf1d 100644 --- a/src/box/wal.c +++ b/src/box/wal.c @@ -951,9 +951,20 @@ wal_assign_lsn(struct vclock *vclock_diff, struct vclock *base, (*row)->tsn = tsn; (*row)->is_commit = row == end - 1; } else { - vclock_follow(vclock_diff, (*row)->replica_id, - (*row)->lsn - vclock_get(base, - (*row)->replica_id)); + int64_t diff = (*row)->lsn - vclock_get(base, (*row)->replica_id); + if (diff <= vclock_get(vclock_diff, + (*row)->replica_id)) { + say_crit("Attempt to write a broken LSN to WAL:" + " replica id: %d, confirmed lsn: %d," + " new lsn %d", (*row)->replica_id, + vclock_get(base, (*row)->replica_id) + + vclock_get(vclock_diff, + (*row)->replica_id), + (*row)->lsn); + assert(0); + } else { + vclock_follow(vclock_diff, (*row)->replica_id, diff); + } } } } -- 2.21.1 (Apple Git-122.3)
next prev parent reply other threads:[~2020-02-18 17:37 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-18 17:37 [Tarantool-patches] [PATCH v3 0/4] replication: fix applying of rows originating from local instance Serge Petrenko 2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 1/4] box: expose box_is_orphan method Serge Petrenko 2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 2/4] recovery: allow to ignore rows coming from a certain instance Serge Petrenko 2020-02-18 19:03 ` Konstantin Osipov 2020-02-19 8:43 ` Serge Petrenko 2020-02-19 8:52 ` Konstantin Osipov 2020-02-19 8:57 ` Serge Petrenko 2020-02-19 9:02 ` Konstantin Osipov 2020-02-19 9:35 ` Serge Petrenko 2020-02-19 10:11 ` Konstantin Osipov 2020-02-19 10:31 ` Serge Petrenko 2020-02-19 11:27 ` Konstantin Osipov 2020-02-18 17:37 ` [Tarantool-patches] [PATCH v3 3/4] replication: do not relay rows coming from a remote instance back to it Serge Petrenko 2020-02-18 19:07 ` Konstantin Osipov 2020-02-18 17:37 ` Serge Petrenko [this message] 2020-02-22 20:21 ` [Tarantool-patches] [PATCH v3 0/4] replication: fix applying of rows originating from local instance Georgy Kirichenko 2020-02-22 20:49 ` Konstantin Osipov 2020-02-23 8:16 ` Georgy Kirichenko 2020-02-24 10:18 ` Konstantin Osipov 2020-02-24 12:31 ` Георгий Кириченко 2020-02-26 10:09 ` Sergey Petrenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b4c230bcf86545f374b4d97e08793e672a4bcdd4.1582046958.git.sergepetrenko@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=kostja.osipov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 4/4] wal: warn when trying to write a record with a broken lsn' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox