Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
	Konstantin Osipov <kostja@tarantool.org>
Cc: vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] Re: [PATCH 1/4] iproto: rename disconnect cmsg to destroy
Date: Tue, 11 Dec 2018 15:54:57 +0300	[thread overview]
Message-ID: <b4294134-2d02-c7b8-ed10-a51d7131ee73@tarantool.org> (raw)
In-Reply-To: <20181207173601.GC840@chai>



On 07/12/2018 20:36, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/12/07 18:48]:
>> Disconnect cmsg is a message that is used by iproto
>> thread to notify tx thread that a connection is dead
>> and has no outstanding requests. That is its
>> tx-related resourses are freed and the connection is
>> deleted.
>>
>> But the text above is clear definition of destroy. The
>> patch harmonizes cmsg name and its puprose.
>>
>> Secondly, the patch is motivated by #3859 which
>> requires separate disconnect and destroy phases.
>>
> 
> OK to push.
> 
>> Needed for #3859
> 

Pushed to 2.1 and 1.10.

  reply	other threads:[~2018-12-11 12:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07 15:46 [PATCH 0/4] Outdate disconnected session Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 1/4] iproto: rename disconnect cmsg to destroy Vladislav Shpilevoy
2018-12-07 17:36   ` [tarantool-patches] " Konstantin Osipov
2018-12-11 12:54     ` Vladislav Shpilevoy [this message]
2018-12-07 15:46 ` [PATCH 2/4] iproto: fire on_disconnect right after disconnect Vladislav Shpilevoy
2018-12-07 17:37   ` [tarantool-patches] " Konstantin Osipov
2018-12-11 12:55     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 3/4] session: introduce 'dead' type Vladislav Shpilevoy
2018-12-07 17:38   ` [tarantool-patches] " Konstantin Osipov
2018-12-07 20:40     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-07 22:21       ` Konstantin Osipov
2018-12-07 22:42         ` Vladislav Shpilevoy
2018-12-07 15:46 ` [PATCH 4/4] session: kill a session of a closed connection Vladislav Shpilevoy
2018-12-07 17:35 ` [tarantool-patches] [PATCH 0/4] Outdate disconnected session Konstantin Osipov
2018-12-11 16:12   ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-07 17:41 ` [tarantool-patches] " Konstantin Osipov
2018-12-11 16:13   ` [tarantool-patches] " Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4294134-2d02-c7b8-ed10-a51d7131ee73@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] Re: [PATCH 1/4] iproto: rename disconnect cmsg to destroy' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox