From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Igor Munkin <imun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2 1/3] box: introduce port_c Date: Sat, 25 Apr 2020 00:06:25 +0200 [thread overview] Message-ID: <b414acb7-7d30-dc23-b8ea-fe55ec673596@tarantool.org> (raw) In-Reply-To: <20200424122235.GH11314@tarantool.org> Hi! Thanks for the review! >> diff --git a/src/box/port.c b/src/box/port.c >> index 6e2fe3a6e..2c1fadb5c 100644 >> --- a/src/box/port.c >> +++ b/src/box/port.c >> @@ -37,7 +37,18 @@ >> #include <fiber.h> >> #include "errinj.h" >> >> -static struct mempool port_tuple_entry_pool; >> +/** >> + * The pools is used both by port_c and port_tuple, since their > > Typo: s/is/are/. Fixed: ==================== diff --git a/src/box/port.c b/src/box/port.c index 2c1fadb5c..eabc19ded 100644 --- a/src/box/port.c +++ b/src/box/port.c @@ -38,7 +38,7 @@ #include "errinj.h" /** - * The pools is used both by port_c and port_tuple, since their + * The pool is used both by port_c and port_tuple, since their * entires are almost of the same size. Also port_c can use * objects from the pool to store result data in their memory, * when it fits.
next prev parent reply other threads:[~2020-04-24 22:06 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-23 0:12 [Tarantool-patches] [PATCH v2 0/3] box_return_mp Vladislav Shpilevoy 2020-04-23 0:12 ` [Tarantool-patches] [PATCH v2 1/3] box: introduce port_c Vladislav Shpilevoy 2020-04-24 12:22 ` Igor Munkin 2020-04-24 22:06 ` Vladislav Shpilevoy [this message] 2020-04-23 0:12 ` [Tarantool-patches] [PATCH v2 2/3] box: introduce box_return_mp() public C function Vladislav Shpilevoy 2020-04-24 12:22 ` Igor Munkin 2020-04-27 15:14 ` Nikita Pettik 2020-04-27 21:29 ` Vladislav Shpilevoy 2020-04-27 22:55 ` Nikita Pettik 2020-04-23 0:12 ` [Tarantool-patches] [PATCH v2 3/3] box: replace port_tuple with port_c everywhere Vladislav Shpilevoy 2020-04-25 0:21 ` Igor Munkin 2020-04-26 19:22 ` Vladislav Shpilevoy 2020-04-27 9:12 ` Igor Munkin 2020-04-27 9:18 ` Igor Munkin 2020-04-27 14:10 ` Nikita Pettik 2020-04-28 11:08 ` [Tarantool-patches] [PATCH v2 0/3] box_return_mp Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b414acb7-7d30-dc23-b8ea-fe55ec673596@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=imun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 1/3] box: introduce port_c' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox