From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua
Date: Sun, 31 May 2020 08:09:41 +0300 [thread overview]
Message-ID: <b3f158c1cfde5a693101a968285aba0cea6c12a1.1590900417.git.avtikhon@tarantool.org> (raw)
Durring investigation of the issues found that error message had
not user friendly format:
local pwgr_errstr = "get%s failed [errno %d]: %s"
produced:
[001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
while it had to be:
[001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
Fixed the error message.
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4592-enoent-pwd-full-ci
src/lua/pwd.lua | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lua/pwd.lua b/src/lua/pwd.lua
index d59594b46..1ea79b5eb 100644
--- a/src/lua/pwd.lua
+++ b/src/lua/pwd.lua
@@ -86,7 +86,7 @@ ffi.cdef[[
-- {{{ Error handling
-local pwgr_errstr = "get%s failed [errno %d]: %s"
+local pwgr_errstr = "get %s failed [errno %d]: %s"
-- Use it in the following way: set errno to zero, call a passwd /
-- group function, then call this function to check whether there
--
2.17.1
next reply other threads:[~2020-05-31 5:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 5:09 Alexander V. Tikhonov [this message]
2020-05-31 5:09 ` [Tarantool-patches] [PATCH v1 2/2] test: remove skip condition of app-tap/pwd test Alexander V. Tikhonov
2020-06-01 8:57 ` Sergey Bronnikov
2020-06-01 10:58 ` Alexander Turenko
2020-06-01 8:57 ` [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua Sergey Bronnikov
2020-06-03 10:13 ` Kirill Yukhin
2020-05-31 5:12 Alexander V. Tikhonov
2020-06-01 10:47 ` Alexander Turenko
2020-06-03 11:37 ` Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f158c1cfde5a693101a968285aba0cea6c12a1.1590900417.git.avtikhon@tarantool.org \
--to=avtikhon@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox