From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/3] tuple: move tuple_update into xrow_update/ folder
Date: Wed, 6 Nov 2019 18:14:02 +0300 [thread overview]
Message-ID: <b3c7bebb-951f-6e1a-a76b-98852927097d@tarantool.org> (raw)
In-Reply-To: <20191104172614.GE29784@atlas>
Thanks for the review!
On 04/11/2019 20:26, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/01 09:55]:
>> Tuple_update.c already uses xrow_update_ namespace. Soon it will
>> have more files extending this namespace. In order to keep them
>> isolated they are moved to a new subfolder box/xrow_update/.
>>
>> Part of #1261
>
> I wonder if we still need this patch. Now that everything is prefixed, why not
> keep it in box?
>
> This is not a standalone library anyway, so I would not create a
> sub-folder for it.
>
>
Ok, I kept xrow_update.c and other new files in box folder. See v2 thread.
next prev parent reply other threads:[~2019-11-06 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 23:43 [Tarantool-patches] [PATCH 0/3] JSON preparation part 5 Vladislav Shpilevoy
2019-10-31 23:43 ` [Tarantool-patches] [PATCH 1/3] tuple: move tuple_update into xrow_update/ folder Vladislav Shpilevoy
2019-11-04 17:26 ` Konstantin Osipov
2019-11-06 15:14 ` Vladislav Shpilevoy [this message]
2019-10-31 23:43 ` [Tarantool-patches] [PATCH 2/3] tuple: rename tuple_update_* to xrow_update_* Vladislav Shpilevoy
2019-11-04 17:26 ` Konstantin Osipov
2019-10-31 23:43 ` [Tarantool-patches] [PATCH 3/3] tuple: rework updates to improve code extendibility Vladislav Shpilevoy
2019-11-04 17:36 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c7bebb-951f-6e1a-a76b-98852927097d@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/3] tuple: move tuple_update into xrow_update/ folder' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox