From: Leonid Vasiliev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Set box.cfg options using environment variables
Date: Thu, 15 Apr 2021 09:04:28 +0300 [thread overview]
Message-ID: <b3a49dee-f21f-5739-4e38-7aee0554388d@tarantool.org> (raw)
In-Reply-To: <cover.1618466243.git.alexander.turenko@tarantool.org>
Hi! Thank you for the patchset.
Great work.
LGTM.
On 4/15/21 9:04 AM, Alexander Turenko wrote:
> https://github.com/tarantool/tarantool/issues/5602
> lvasilev/env
> https://github.com/tarantool/tarantool/tree/lvasilev/env
>
> No test case for tarantoolctl, sorry. Tested manually.
>
> Cyrill Gorcunov (1):
> cfg: provide types for logger options
>
> Roman Khabibov (1):
> box: set box.cfg options via environment variables
>
> changelogs/unreleased/environment-cfg.md | 7 ++
> extra/dist/tarantoolctl.in | 19 ++-
> src/box/lua/load_cfg.lua | 111 ++++++++++++++++++
> .../gh-5602-environment-cfg-test-cases.lua | 71 +++++++++++
> .../gh-5602-environment-vars-cfg.result | 33 ++++++
> .../gh-5602-environment-vars-cfg.test.lua | 57 +++++++++
> 6 files changed, 297 insertions(+), 1 deletion(-)
> create mode 100755 changelogs/unreleased/environment-cfg.md
> create mode 100755 test/box-tap/gh-5602-environment-cfg-test-cases.lua
> create mode 100644 test/box-tap/gh-5602-environment-vars-cfg.result
> create mode 100755 test/box-tap/gh-5602-environment-vars-cfg.test.lua
>
next prev parent reply other threads:[~2021-04-15 6:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 6:04 Alexander Turenko via Tarantool-patches
2021-04-15 6:04 ` [Tarantool-patches] [PATCH 1/2] cfg: provide types for logger options Alexander Turenko via Tarantool-patches
2021-04-15 6:04 ` [Tarantool-patches] [PATCH 2/2] box: set box.cfg options via environment variables Alexander Turenko via Tarantool-patches
2021-04-15 6:04 ` Leonid Vasiliev via Tarantool-patches [this message]
2021-04-15 6:13 ` [Tarantool-patches] [PATCH 0/2] Set box.cfg options using " Cyrill Gorcunov via Tarantool-patches
2021-04-15 6:52 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3a49dee-f21f-5739-4e38-7aee0554388d@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=lvasiliev@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Set box.cfg options using environment variables' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox