From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 86C3B6EC5F; Thu, 15 Apr 2021 09:06:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 86C3B6EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618466766; bh=Y8b+ZjEC3ifgeXLvtLcflQFPYS7GCNqI6yttvESE88s=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=A2TlZgXid8KMzIz3gJYnkm0mk5f49LfjrONeLNlyJbgF+zIu9XEK+5oNVGKKu8+PQ wAS+4Ep7Hu3TkM6YxTnv86uiNVqRRRCDWklai2mnW6QMm8Fq86oY6QnJTR23J1RBG8 YoDxD1BfQRXfim/s5GUB3tAT9CbVG5OTgc7HWBQ0= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7ECCC6EC5F for ; Thu, 15 Apr 2021 09:06:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7ECCC6EC5F Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1lWv8e-0007GF-Ov; Thu, 15 Apr 2021 09:06:05 +0300 To: Alexander Turenko References: Message-ID: Date: Thu, 15 Apr 2021 09:04:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480B1C8842CE613979723F2FB4628545A35182A05F538085040983AB066181BDD52EE3D5BD0713D84599769A6EB9F9B7C825A148A226A76BD9B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B3D52627AD81B52CEA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA658590BA83A36E41104DC9B6C5DF8FB3B59F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD2691661749BA6B9773583B924D585AFE3657B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050FB1593CA6EC85F86D03CEA74F0D118906B3661434B16C20AC78D18283394535A9E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6ADF66F6ECF73CEB4089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5F0086201FAAB232F0CF5318387C43E56E7427928C882A5BBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345DE7771146E56B0885B08BB8324EE479697C40AD421CF2032660315349B540647C5F90622724417A1D7E09C32AA3244CAB7B5F451C3A2A6EB874BF73C11080E260759606DA2E136AFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrcJA+pXcDumT1edEvgT1rQ== X-Mailru-Sender: 48EFD2E18A91C559803250E574CC3D29E9EB8FC1A8B3FA90EE3D5BD0713D8459CA71892AC981DD5FD35D514C7DAC97282D063C67CFD4E84987597EC79699C0E6F21BD4036121A32F7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/2] Set box.cfg options using environment variables X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Leonid Vasiliev via Tarantool-patches Reply-To: Leonid Vasiliev Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the patchset. Great work. LGTM. On 4/15/21 9:04 AM, Alexander Turenko wrote: > https://github.com/tarantool/tarantool/issues/5602 > lvasilev/env > https://github.com/tarantool/tarantool/tree/lvasilev/env > > No test case for tarantoolctl, sorry. Tested manually. > > Cyrill Gorcunov (1): > cfg: provide types for logger options > > Roman Khabibov (1): > box: set box.cfg options via environment variables > > changelogs/unreleased/environment-cfg.md | 7 ++ > extra/dist/tarantoolctl.in | 19 ++- > src/box/lua/load_cfg.lua | 111 ++++++++++++++++++ > .../gh-5602-environment-cfg-test-cases.lua | 71 +++++++++++ > .../gh-5602-environment-vars-cfg.result | 33 ++++++ > .../gh-5602-environment-vars-cfg.test.lua | 57 +++++++++ > 6 files changed, 297 insertions(+), 1 deletion(-) > create mode 100755 changelogs/unreleased/environment-cfg.md > create mode 100755 test/box-tap/gh-5602-environment-cfg-test-cases.lua > create mode 100644 test/box-tap/gh-5602-environment-vars-cfg.result > create mode 100755 test/box-tap/gh-5602-environment-vars-cfg.test.lua >