From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] ci: make GitHub workflows more CMake-ish
Date: Fri, 3 Jun 2022 13:15:17 +0300 [thread overview]
Message-ID: <b35665b5-9931-d42e-35f7-427c910838f4@tarantool.org> (raw)
In-Reply-To: <YpjeijSClWO0v82Y@tarantool.org>
Thanks for changes!
LGTM now with one note - seems passing "--parallel" for target
"LuaJIT-luacheck" is useless because:
1. luacheck requires LuaLanes for enabling multithreading and it is not
installed in LuaJIT CI
2. option "--jobs" is not passed for luacheck in test/CMakeLists.txt
Feel free to keep patch as is, we can enable option "--jobs" and install
required LuaLanes module later
in a separate patch.
Sergey
On 02.06.2022 19:00, Igor Munkin wrote:
> <snipped>
> ================================================================================
>
> diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
> index c629e5f4..3091c10b 100644
> --- a/.github/workflows/lint.yml
> +++ b/.github/workflows/lint.yml
> @@ -45,4 +45,4 @@ jobs:
> - name: configure
> run: cmake .
> - name: test
> - run: cmake --build . --parallel --target LuaJIT-luacheck
> + run: cmake --build . --parallel $(($(nproc) + 1) --target LuaJIT-luacheck
>
<snipped>
next prev parent reply other threads:[~2022-06-03 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 15:54 Igor Munkin via Tarantool-patches
2022-06-02 7:45 ` Sergey Kaplun via Tarantool-patches
2022-06-06 10:19 ` Igor Munkin via Tarantool-patches
2022-06-02 12:25 ` Sergey Bronnikov via Tarantool-patches
2022-06-02 16:00 ` Igor Munkin via Tarantool-patches
2022-06-03 10:15 ` Sergey Bronnikov via Tarantool-patches [this message]
2022-06-06 10:18 ` Igor Munkin via Tarantool-patches
2022-06-20 12:47 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35665b5-9931-d42e-35f7-427c910838f4@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] ci: make GitHub workflows more CMake-ish' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox