From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 95C2B6EFDA; Fri, 3 Jun 2022 13:15:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 95C2B6EFDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1654251322; bh=hDvPCVJi+3FNZULMKcPZr//kTokNKicG++BjM2pGYRY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=K6toRC+xvhnq8an6fhnQDy8NMDIg/uj57i3YQu+7Cs9/AqHQCYvuImm/RUML8QSgF djmRFylAikbBdeG0q0T/ttc4NeVeMnlz5/xX5QYgw2wa6HXkBONAmYSSHa8tRISLOp p5EEhuzXFM2SxGuO2F1g1Bqahtk1jEAske6rMXFU= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2F62B6EFDA for ; Fri, 3 Jun 2022 13:15:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F62B6EFDA Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1nx4Ks-0000cX-7W; Fri, 03 Jun 2022 13:15:18 +0300 Message-ID: Date: Fri, 3 Jun 2022 13:15:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Igor Munkin References: <8826142ef8ae2e352728e3b4fdf5390851fe2e25.1654098694.git.imun@tarantool.org> <58ae0b0e-387a-2171-1d3b-dbdfa746c421@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A866A199C4CD7E10667ED900E21AD17D8C41DC14F88CD986182A05F53808504086F127D3CE3AE94AC0CD9F670011FC1522CEB19703427C2886CAC7F831193A31 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE749E89BD568380EECC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE779AAD18609327F83EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BEBC5CAB6D411FFA648E8371969A336FD30AE207A0E7FF44ECC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D2DCF9CF1F528DBCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BE3626BA53F019D7675ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5B11AA50A912D6C597C5B619D62886E56684338353361CD26D59269BC5F550898D99A6476B3ADF6B4886A5961035A09600383DAD389E261318FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346AD04FDA812EEFF163981C03136470F28353B49EC1A52799F55DCEF8C57D4331D118E78B7574F7621D7E09C32AA3244C5B2CCEA2969AD10735F7CE3B9FA9510DE646F07CC2D4F3D8FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojZQX5hKFvZ7GQko5KvRsLVA== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D6D747525F59C3A87600634865E5A74A66DD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: make GitHub workflows more CMake-ish X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for changes! LGTM now with one note - seems passing "--parallel" for target "LuaJIT-luacheck" is useless because: 1. luacheck requires LuaLanes for enabling multithreading and it is not installed in LuaJIT CI 2. option "--jobs" is not passed for luacheck in test/CMakeLists.txt Feel free to keep patch as is, we can enable option "--jobs" and install required LuaLanes module later in a separate patch. Sergey On 02.06.2022 19:00, Igor Munkin wrote: > > ================================================================================ > > diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml > index c629e5f4..3091c10b 100644 > --- a/.github/workflows/lint.yml > +++ b/.github/workflows/lint.yml > @@ -45,4 +45,4 @@ jobs: > - name: configure > run: cmake . > - name: test > - run: cmake --build . --parallel --target LuaJIT-luacheck > + run: cmake --build . --parallel $(($(nproc) + 1) --target LuaJIT-luacheck >