Re: [Tarantool-patches] [PATCH luajit 2/3] Restore state when recording __concat metamethod throws OOM.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

Thanks! LGTM

On 11.03.2025 15:37, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Fixed your comment and force-pushed the branch.
>
> On 11.03.25, Sergey Bronnikov wrote:
>> Hi, Sergey,
>>
>> thanks for the patch! LGTM with a minor comment below.
>>
>> Sergey
>>
>> On 10.03.2025 17:51, Sergey Kaplun wrote:
> <snipped>
>
>>> +local bigstr = string.rep('x', ALLOC_LIMIT)
>>> +local __concat = function()
>>> +  return 'concated'
>> s/concated/concatenated/
> Fixed, thanks:
>
> ===================================================================
> diff --git a/test/tarantool-tests/lj-1298-oom-on-concat-recording.test.lua b/test/tarantool-tests/lj-1298-oom-on-concat-recording.test.lua
> index 961df798..20d93c43 100644
> --- a/test/tarantool-tests/lj-1298-oom-on-concat-recording.test.lua
> +++ b/test/tarantool-tests/lj-1298-oom-on-concat-recording.test.lua
> @@ -20,7 +20,7 @@ local ALLOC_LIMIT = 2048
>   
>   local bigstr = string.rep('x', ALLOC_LIMIT)
>   local __concat = function()
> -  return 'concated'
> +  return 'concatenated'
>   end
>   
>   -- Need to use metamethod call in the concat recording.
> ===================================================================
>
> I've also checked that this is not ruined the testcase.
>
>>
>> <snipped>

[-- Attachment #2: Type: text/html, Size: 2182 bytes --]