From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
Konstantin Osipov <kostja.osipov@gmail.com>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: invalid integer type in arithmetic operations
Date: Thu, 25 Apr 2019 14:07:56 +0300 [thread overview]
Message-ID: <b32fe827-2037-c44f-8abe-c0a56568226a@tarantool.org> (raw)
In-Reply-To: <20190425105237.GA2297@atlas>
>> SQL *is* server. Please begin by having a comment containing a
>> table for integer type arithmetics, something like this:
>>
>> Plus operation:
>> --------------
>>
>> integer float
>>
>> integer integer float
>> float float float
>>
>> It's best to implement such table in the source code too, and not
>> have complicated branching.
>
> Re UNSIGNED type itself:
>
> once you have a proper table for type arithmetics, it will be easy
> to understand what the result of unsigned + unsigned should be.
> Most likely it should be unsigned, not a number.
Exactly this logic is already on master branch (but only with few sequential ifs, not a table).
next prev parent reply other threads:[~2019-04-25 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 15:36 [tarantool-patches] " Kirill Shcherbatov
2019-04-24 19:43 ` [tarantool-patches] " n.pettik
2019-04-25 7:32 ` Kirill Shcherbatov
2019-04-24 19:56 ` Vladislav Shpilevoy
2019-04-24 23:03 ` n.pettik
2019-04-25 10:49 ` Konstantin Osipov
2019-04-25 10:52 ` Konstantin Osipov
2019-04-25 11:07 ` Kirill Shcherbatov [this message]
2019-04-25 11:15 ` Konstantin Osipov
2019-04-25 11:21 ` Kirill Shcherbatov
2019-04-25 10:37 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b32fe827-2037-c44f-8abe-c0a56568226a@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: invalid integer type in arithmetic operations' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox