From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Timur Safin <tsafin@tarantool.org>,
'Aleksandr Lyapunov' <alyapunov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] alter: use good c++ style
Date: Tue, 14 Jul 2020 00:17:42 +0200 [thread overview]
Message-ID: <b1c42f0a-80c0-6ce7-d2b8-20e40a83b813@tarantool.org> (raw)
In-Reply-To: <0e5801d6595f$b935e310$2ba1a930$@tarantool.org>
> : @@ -1475,7 +1471,7 @@ CreateIndex::prepare(struct alter_space *alter)
> : }
> :
> : void
> : -CreateIndex::commit(struct alter_space *alter, int64_t signature)
> : +CreateIndex::commit(struct alter_space *alter, int64_t signature)
> : noexcept
> : {
> : (void) alter;
>
> The same comment is applicable here - we could simply omit argument name
Argument name omission reduces code readability. We have already had
that discussion in Lua because of luacheck requiring to drop some
arguments. But it does not make the code better really.
> : - ++schema_version;
> : + (void) alter;
> : + ++schema_version;
>
> But here we could ask _very important question_ (:)) do we use spaces
> or tabs (like in C) for indenting C++ sources? Looks like Tabs are not yet
> used in this file, thus no need to enforce the different style.
Alter.cc uses tabs only. Except this place probably.
next prev parent reply other threads:[~2020-07-13 22:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 9:07 [Tarantool-patches] [PATCH 0/2] Simplify alter.cc Aleksandr Lyapunov
2020-07-08 9:07 ` [Tarantool-patches] [PATCH 1/2] alter: use good c++ style Aleksandr Lyapunov
2020-07-11 19:53 ` Vladislav Shpilevoy
2020-07-13 13:36 ` Aleksandr Lyapunov
2020-07-13 18:33 ` Vladislav Shpilevoy
2020-07-13 21:51 ` Timur Safin
2020-07-13 22:17 ` Vladislav Shpilevoy [this message]
2020-07-08 9:07 ` [Tarantool-patches] [PATCH 2/2] alter: use proper way to marry C and C++ Aleksandr Lyapunov
2020-07-08 10:41 ` Timur Safin
2020-07-11 19:53 ` Vladislav Shpilevoy
2020-07-08 9:13 ` [Tarantool-patches] [PATCH 0/2] Simplify alter.cc Aleksandr Lyapunov
2020-07-08 10:35 ` Timur Safin
-- strict thread matches above, loose matches on Subject: below --
2020-07-08 8:43 Aleksandr Lyapunov
2020-07-08 8:43 ` [Tarantool-patches] [PATCH 1/2] alter: use good c++ style Aleksandr Lyapunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1c42f0a-80c0-6ce7-d2b8-20e40a83b813@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] alter: use good c++ style' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox