Re: [Tarantool-patches] [PATCH v21 3/6] box/module_cache: introduce modules subsystem

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

I appreciate the work you did here!

The patch looks good. Only one question below.

> diff --git a/src/box/module_cache.c b/src/box/module_cache.c
> new file mode 100644
> index 000000000..3dcb40566
> --- /dev/null
> +++ b/src/box/module_cache.c
> @@ -0,0 +1,491 @@

<...>

> +
> +void
> +module_free(void)
> +{
> +	while (mh_size(module_cache) > 0) {
> +		mh_int_t e = mh_first(module_cache);
> +		mh_strnptr_del(module_cache, e, NULL);

Is this loop really needed? It seems the mhash delete()
frees all the memory anyway.

> +	}
> +	mh_strnptr_delete(module_cache);
> +	module_cache = NULL;
> +}