Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Oleg Piskunov <o.piskunov@tarantool.org>,
	Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources
Date: Tue, 26 May 2020 17:42:32 +0300	[thread overview]
Message-ID: <b07b25b57cb46c9d1c618ee3c1bf9189b77c1525.1590503508.git.avtikhon@tarantool.org> (raw)
In-Reply-To: <cover.1590503508.git.avtikhon@tarantool.org>
In-Reply-To: <cover.1590503508.git.avtikhon@tarantool.org>

Building Tarantool sources on make command run may fail with:

  [ 10%] make[2]: *** [test/small] Error 1
  [ 10%] make[1]: *** [test/CMakeFiles/symlink_small_tests.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....

The root cause of the issue that Dockerfile.staticbuild
uses local copy of sources:

  COPY . /tarantool

Which may have broken links in tests, like:

  $ ls -al test
  ...
  luajit-tap -> /<wrong path>/third_party/luajit/test
  small -> /<wrong path>/src/lib/small/test/
  ...

To fix the issue this links should be removed from
the docker local copy of sources before build, like:

  rm -rf test/small test/luajit-tap

Closes #5025
---
 Dockerfile.staticbuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
index 253f2d5e9..f67f46f5e 100644
--- a/Dockerfile.staticbuild
+++ b/Dockerfile.staticbuild
@@ -75,7 +75,7 @@ RUN set -x && \
 RUN set -x && \
     find . -name 'CMakeFiles' -type d -exec rm -rf {} + && \
     find . -name 'CMakeCache.txt' -type f -delete && \
-    rm -rf build
+    rm -rf build test/small test/luajit-tap
 
 RUN pip install -r /tarantool/test-run/requirements.txt
 
-- 
2.17.1

  reply	other threads:[~2020-05-26 14:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 14:42 [Tarantool-patches] [PATCH v2 0/7] Implement OOS build Alexander V. Tikhonov
2020-05-26 14:42 ` Alexander V. Tikhonov [this message]
2020-06-26 13:51   ` [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources Alexander Turenko
2020-07-03 11:13   ` Kirill Yukhin
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 2/7] build: fix static build w/ dockerfile with cmake Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 3/7] build: enable cmake in curl build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 4/7] Fix curl repository for out-of-source build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 5/7] build: change autoconf to cmake in curl build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 6/7] Skip failing test from out-of-source build Alexander V. Tikhonov
2020-05-26 14:42 ` [Tarantool-patches] [PATCH v2 7/7] gitlab-ci: add " Alexander V. Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b07b25b57cb46c9d1c618ee3c1bf9189b77c1525.1590503508.git.avtikhon@tarantool.org \
    --to=avtikhon@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox