From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] ci: run ARM64 jobs on GitHub-hosted runners
Date: Wed, 14 Oct 2026 13:46:25 +0300 [thread overview]
Message-ID: <as9dgYSzHeHKkTUX@root> (raw)
In-Reply-To: <a8fa049d-21d2-4563-befe-d25cfdd01974@tarantool.org>
Hi, Alexander!
Thanks for the patch!
LGTM, after resolving Sergey's comment below.
On 02.10.26, Sergey Bronnikov wrote:
> Hi, Alexander,
>
> thanks for the patch! LGTM with minor comment
>
> Sergey
>
> On 10/1/26 04:06, Alexander Turenko wrote:
> > The main idea behind the switch is to have less of our own
> > infrastructure to support, see tarantool/tarantool#13278 for details.
> >
> > Drafted by an LLM, conducted and corrected by the commit author.
> > ---
> > .github/workflows/debuggers.yml | 3 ++-
> > .github/workflows/exotic-builds-testing.yml | 3 ++-
> > .github/workflows/gnumake-builds-testing.yml | 5 ++++-
> > .github/workflows/testing.yml | 5 ++++-
> > 4 files changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git a/.github/workflows/debuggers.yml b/.github/workflows/debuggers.yml
> > index 489c2bed..d8b53fda 100644
> > --- a/.github/workflows/debuggers.yml
> > +++ b/.github/workflows/debuggers.yml
> > @@ -36,7 +36,8 @@ jobs:
> > exclude:
> > - ARCH: ARM64
> > GC64: OFF
> > - runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']
> > + runs-on: ${{ matrix.ARCH == 'ARM64' && 'ubuntu-26.04-arm' ||
> > + fromJSON('["self-hosted", "regular", "Linux", "x86_64"]') }}
>
> after the patch we will use github runners and it is worth set a timeout
> for jobs,
>
> otherwise we might run out of time on the runners (AFAIK it is limited
> there).
Agree here. IINM, the default is 6 hours [1], which is too much for our
tests.
The longest job is Valgrind job, which is running about 12 minutes.
I suppose the limit of 30 minutes is reasonable.
<snipped>
[1]: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idtimeout-minutes
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2026-10-14 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 1:06 [Tarantool-patches] [PATCH 0/2] Use GitHub-hosted runners for Linux/ARM64 jobs Alexander Turenko via Tarantool-patches
2026-10-01 1:06 ` [Tarantool-patches] [PATCH 1/2] ci: use sudo to install packages if not root Alexander Turenko via Tarantool-patches
2026-10-02 13:18 ` Sergey Bronnikov via Tarantool-patches
2026-10-14 9:57 ` Sergey Kaplun via Tarantool-patches
2026-10-01 1:06 ` [Tarantool-patches] [PATCH 2/2] ci: run ARM64 jobs on GitHub-hosted runners Alexander Turenko via Tarantool-patches
2026-10-02 13:24 ` Sergey Bronnikov via Tarantool-patches
2026-10-14 10:46 ` Sergey Kaplun via Tarantool-patches [this message]
2026-10-14 12:58 ` Alexander Turenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as9dgYSzHeHKkTUX@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] ci: run ARM64 jobs on GitHub-hosted runners' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox