Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>,
	Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] ci: run ARM64 jobs on GitHub-hosted runners
Date: Fri, 2 Oct 2026 16:24:44 +0300	[thread overview]
Message-ID: <a8fa049d-21d2-4563-befe-d25cfdd01974@tarantool.org> (raw)
In-Reply-To: <1cfe37548b12811dc0e57a01f61f6a361daa2071.1790815412.git.alexander.turenko@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 3510 bytes --]

Hi, Alexander,

thanks for the patch! LGTM with minor comment

Sergey

On 10/1/26 04:06, Alexander Turenko wrote:
> The main idea behind the switch is to have less of our own
> infrastructure to support, see tarantool/tarantool#13278 for details.
>
> Drafted by an LLM, conducted and corrected by the commit author.
> ---
>   .github/workflows/debuggers.yml              | 3 ++-
>   .github/workflows/exotic-builds-testing.yml  | 3 ++-
>   .github/workflows/gnumake-builds-testing.yml | 5 ++++-
>   .github/workflows/testing.yml                | 5 ++++-
>   4 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/.github/workflows/debuggers.yml b/.github/workflows/debuggers.yml
> index 489c2bed..d8b53fda 100644
> --- a/.github/workflows/debuggers.yml
> +++ b/.github/workflows/debuggers.yml
> @@ -36,7 +36,8 @@ jobs:
>           exclude:
>             - ARCH: ARM64
>               GC64: OFF
> -    runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']
> +    runs-on: ${{ matrix.ARCH == 'ARM64' && 'ubuntu-26.04-arm' ||
> +                 fromJSON('["self-hosted", "regular", "Linux", "x86_64"]') }}

after the patch we will use github runners and it is worth set a timeout 
for jobs,

otherwise we might run out of time on the runners (AFAIK it is limited 
there).

>       name: >
>         LuaJIT
>         (${{ matrix.ARCH }})
> diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
> index 0c575404..568d6be3 100644
> --- a/.github/workflows/exotic-builds-testing.yml
> +++ b/.github/workflows/exotic-builds-testing.yml
> @@ -76,7 +76,8 @@ jobs:
>             # (`DASM_S_RANGE_I`).
>             - FLAVOR: tablebump
>               ARCH: ARM64
> -    runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']
> +    runs-on: ${{ matrix.ARCH == 'ARM64' && 'ubuntu-26.04-arm' ||
> +                 fromJSON('["self-hosted", "regular", "Linux", "x86_64"]') }}
>       name: >
>         LuaJIT ${{ matrix.FLAVOR }}
>         (Linux/${{ matrix.ARCH }})
> diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
> index 1b64b040..56dae7f8 100644
> --- a/.github/workflows/gnumake-builds-testing.yml
> +++ b/.github/workflows/gnumake-builds-testing.yml
> @@ -52,7 +52,10 @@ jobs:
>               GC64: OFF
>             - OS: macOS
>               GC64: OFF
> -    runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']
> +    runs-on: ${{ matrix.OS == 'Linux' && matrix.ARCH == 'ARM64' &&
> +                 'ubuntu-26.04-arm' ||
> +                 fromJSON(format('["self-hosted", "regular", "{0}", "{1}"]',
> +                                 matrix.OS, matrix.ARCH)) }}
>       name: >
>         LuaJIT
>         (${{ matrix.OS }}/${{ matrix.ARCH }})
> diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
> index e39e2ec7..5448247f 100644
> --- a/.github/workflows/testing.yml
> +++ b/.github/workflows/testing.yml
> @@ -59,7 +59,10 @@ jobs:
>             - ARCH: ARM64
>               OS: Linux
>               CC: clang
> -    runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']
> +    runs-on: ${{ matrix.OS == 'Linux' && matrix.ARCH == 'ARM64' &&
> +                 'ubuntu-26.04-arm' ||
> +                 fromJSON(format('["self-hosted", "regular", "{0}", "{1}"]',
> +                                 matrix.OS, matrix.ARCH)) }}
>       name: >
>         LuaJIT
>         (${{ matrix.OS }}/${{ matrix.ARCH }})

[-- Attachment #2: Type: text/html, Size: 4154 bytes --]

      reply	other threads:[~2026-10-02 13:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01  1:06 [Tarantool-patches] [PATCH 0/2] Use GitHub-hosted runners for Linux/ARM64 jobs Alexander Turenko via Tarantool-patches
2026-10-01  1:06 ` [Tarantool-patches] [PATCH 1/2] ci: use sudo to install packages if not root Alexander Turenko via Tarantool-patches
2026-10-02 13:18   ` Sergey Bronnikov via Tarantool-patches
2026-10-01  1:06 ` [Tarantool-patches] [PATCH 2/2] ci: run ARM64 jobs on GitHub-hosted runners Alexander Turenko via Tarantool-patches
2026-10-02 13:24   ` Sergey Bronnikov via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8fa049d-21d2-4563-befe-d25cfdd01974@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 2/2] ci: run ARM64 jobs on GitHub-hosted runners' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox