Re: [Tarantool-patches] [PATCH luajit v4] dbg: display fast function name along with ffid

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Mikhail!
Thanks for the patch!
LGTM, with minor nits below.

On 07.10.26, Mikhail Elhimov wrote:

<snipped>

> diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py
> index 7c2d085f..1d553fb9 100644
> --- a/src/luajit_dbg.py
> +++ b/src/luajit_dbg.py

<snipped>

> diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
> index 5e369f00..b6e51185 100644
> --- a/test/tarantool-debugger-tests/debug-extension-tests.py
> +++ b/test/tarantool-debugger-tests/debug-extension-tests.py

<snipped>

>      # Sorted in LJT order.
>      lua_script = (
>          'local ffi = require("ffi")\n'
> +        'local math = require("math")\n'

Minor: This change is excess. math library is loaded by default.

<snipped>

>  class TestLJGCo(TestCaseBase):
>      location = 'lj_cf_print'
> -    extension_cmds = (
> -        'lj-gco ' + gcval('L->base + 0') + '\n'
> -        'lj-gco ' + gcval('L->base + 1') + '\n'
> -        'lj-gco ' + gcval('L->base + 2') + '\n'
> -        'lj-gco ' + gcval('L->base + 3') + '\n'
> -        'lj-gco ' + gcval('L->base + 4') + '\n'
> -        'lj-gco ' + gcval('L->base + 5') + '\n'
> -        'lj-gco ' + gcval('L->base + 6') + '\n'
> -        'lj-gco ' + gcval('L->base + 7') + '\n'
> +    extension_cmds = ''.join(
> +        ('lj-gco ' + gcval('L->base + {}'.format(i)) + '\n'
> +         for i in range(GCO_ARGS.count('\n')))
>      )
>  
>      lua_script = (
>          'local ffi = require("ffi")\n'
> +        'local math = require("math")\n'

Minor: This change is excess. math library is loaded by default.

>          'print(\n' +
>          GCO_ARGS +
>          '  1\n'  # Stub for the pattern.
> @@ -444,6 +453,66 @@ class TestLJGCo(TestCaseBase):

<snipped>

> +class TestLJFuncFFKnown(TestCaseBase):
> +    location = 'lj_cf_print'
> +    extension_cmds = ''.join(
> +        ('lj-func ' + gcval('L->base + {}'.format(i)) + '\n'
> +         for i in range(FFUNC_ARGS.count('\n')))
> +    )
> +
> +    lua_script = (
> +        'local math = require("math")\n'

Minor: This change is excess. math library is loaded by default.

<snipped>

> -- 
> 2.43.0
> 

-- 
Best regards,
Sergey Kaplun