From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 662726ECCC; Wed, 14 Oct 2026 12:54:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 662726ECCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1791971661; bh=FjngfrzD/rx0NarB31mtoTiWGCkcacmNibxlLGMQU/w=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dGD2Sob3twnP2sT4OYZ+FjdRGyfELd2+sGbuPc/XVCBYjqidk+GCyprjEw1JwN0k6 iD3OUECb58svyxpf+R3daFSzgRMuzcROgRly2E8Sf5bSektkAax7k4MVIUwG2hFYUC ud9qsLk8i2GR9DQ8xHNTiqeT69tIOqMKYljqSRek= Received: from send106.i.mail.ru (send106.i.mail.ru [89.221.237.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0E9D16ECCC for ; Wed, 14 Oct 2026 12:54:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0E9D16ECCC Received: by exim-smtp-84d6fb566c-h7fjv with esmtpa (envelope-from ) id 1xGvgg-00000000EjW-040b; Wed, 14 Oct 2026 12:54:18 +0300 Date: Wed, 14 Oct 2026 12:53:55 +0300 To: Mikhail Elhimov Message-ID: References: <20261007163315.115049-1-m.elhimov@vk.team> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261007163315.115049-1-m.elhimov@vk.team> X-Mailru-Src: smtp X-4EC0790: 10 X-618D5548: 40DE8C7ACB10E92803ED270C30F246C5D373E305920339AE19DCC22A5683E46B061958B49C08C7F0 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A0706A514393B94502AC9ED1DCB40F758C8BA8A18CF60442182A05F5380850404C228DA9ACA6FE27FFBB39AE2848BA893DE06ABAFEAF6705315E65AA7ACE1F9785313735FB9B13AEE54C7BE71C4A8023 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE769420192704DB0E7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566BB3FA6B37D7AB46BC18729E753A5154499FC49A8AC3541189C0ACEDAFD526FB4389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8090A508E0FED6299176DF2183F8FC7C0606689D8DEF8F533CD04E86FAF290E2DB606B96278B59C421DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B642416645EBD45DC2089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A55DF04C0DBEA338635002B1117B3ED696BEF9885EED5E2DF6361FAC1196A180DE3610D81D389A125CDE35189EBF2DEA28FEA14CD2CD220BB99C5DF10A05D560A9880EC71AF561E0AAD9143641EC25BB39D63E3A0C264D9A6D X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6599AA04EE944D1BF5DE3D3E3AF416A06FC6F2C55CF8A2DF0C4F9EDB7B1D0D23BF21953EAA70B4F512EB8341EE9D5BE9A0AD657658F971832FD5D9CAA9CBE7B0CC474C1F8E1650A60D2C7CEAA0681F5848F4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWM8lRrEM25OvAP+qXqN/L60= X-Mailru-Sender: 520A125C2F17F0B17094CDC02B85F11BE84D3575D14DBF273DE06ABAFEAF6705315E65AA7ACE1F97B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4] dbg: display fast function name along with ffid X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Mikhail! Thanks for the patch! LGTM, with minor nits below. On 07.10.26, Mikhail Elhimov wrote: > diff --git a/src/luajit_dbg.py b/src/luajit_dbg.py > index 7c2d085f..1d553fb9 100644 > --- a/src/luajit_dbg.py > +++ b/src/luajit_dbg.py > diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py > index 5e369f00..b6e51185 100644 > --- a/test/tarantool-debugger-tests/debug-extension-tests.py > +++ b/test/tarantool-debugger-tests/debug-extension-tests.py > # Sorted in LJT order. > lua_script = ( > 'local ffi = require("ffi")\n' > + 'local math = require("math")\n' Minor: This change is excess. math library is loaded by default. > class TestLJGCo(TestCaseBase): > location = 'lj_cf_print' > - extension_cmds = ( > - 'lj-gco ' + gcval('L->base + 0') + '\n' > - 'lj-gco ' + gcval('L->base + 1') + '\n' > - 'lj-gco ' + gcval('L->base + 2') + '\n' > - 'lj-gco ' + gcval('L->base + 3') + '\n' > - 'lj-gco ' + gcval('L->base + 4') + '\n' > - 'lj-gco ' + gcval('L->base + 5') + '\n' > - 'lj-gco ' + gcval('L->base + 6') + '\n' > - 'lj-gco ' + gcval('L->base + 7') + '\n' > + extension_cmds = ''.join( > + ('lj-gco ' + gcval('L->base + {}'.format(i)) + '\n' > + for i in range(GCO_ARGS.count('\n'))) > ) > > lua_script = ( > 'local ffi = require("ffi")\n' > + 'local math = require("math")\n' Minor: This change is excess. math library is loaded by default. > 'print(\n' + > GCO_ARGS + > ' 1\n' # Stub for the pattern. > @@ -444,6 +453,66 @@ class TestLJGCo(TestCaseBase): > +class TestLJFuncFFKnown(TestCaseBase): > + location = 'lj_cf_print' > + extension_cmds = ''.join( > + ('lj-func ' + gcval('L->base + {}'.format(i)) + '\n' > + for i in range(FFUNC_ARGS.count('\n'))) > + ) > + > + lua_script = ( > + 'local math = require("math")\n' Minor: This change is excess. math library is loaded by default. > -- > 2.43.0 > -- Best regards, Sergey Kaplun