From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/3] build: fixed making tests with ASAN on OSX
Date: Tue, 4 Aug 2026 23:53:32 +0300 [thread overview]
Message-ID: <anJRTMpSl9M0S63X@root> (raw)
In-Reply-To: <bfb2fa82a5c0715f9e0f9c1e10c37899105ca75d.1785521480.git.e.temirgaleev@tarantool.org>
Sorry, I've noticed some nits regarding the commit message.
LGTM, after fixing.
> build: fixed making tests with ASAN on OSX
It also may use tag `test:`, Feel free to ignore.
On 31.07.26, Evgeniy Temirgaleev wrote:
> From: Temir Galeev <temir.galeev@bk.ru>
>
> LuaJIT tests use fixup for Linux to run binaries maked with ASAN option.
Typo: s/maked/made/ or s/maked/built/
Typo: s/ASAN/the ASAN/
> The our LibRealPath module used for it. This module doesn't support OSX
Typo: s/The our/Our/
Typo: s/used/is used/
> and breaks the make process.
>
> So, we disable the fixup for OSX to allow LuaJIT making and running the tests
Commit message body is more than 72 symbols [1].
> with ASAN enabled.
<snipped>
[1]: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2026-08-04 20:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 19:11 [Tarantool-patches] [PATCH luajit v2 0/3] " Evgeniy Temirgaleev via Tarantool-patches
2026-07-31 19:12 ` [Tarantool-patches] [PATCH luajit v2 1/3] " Evgeniy Temirgaleev via Tarantool-patches
2026-08-04 12:59 ` Sergey Kaplun via Tarantool-patches
2026-08-04 20:53 ` Sergey Kaplun via Tarantool-patches [this message]
2026-08-05 19:27 ` Evgeniy Temirgaleev via Tarantool-patches
2026-07-31 19:12 ` [Tarantool-patches] [PATCH luajit v2 2/3] ci: enabled sanitizer tests for macOS Evgeniy Temirgaleev via Tarantool-patches
2026-08-04 12:55 ` Sergey Kaplun via Tarantool-patches
2026-08-05 19:48 ` Evgeniy Temirgaleev via Tarantool-patches
2026-07-31 19:12 ` [Tarantool-patches] [PATCH luajit v2 3/3] ci: added a common way to disable perfomance workflow Evgeniy Temirgaleev via Tarantool-patches
2026-08-04 13:00 ` Sergey Kaplun via Tarantool-patches
2026-08-04 20:48 ` Sergey Kaplun via Tarantool-patches
2026-08-05 19:30 ` Evgeniy Temirgaleev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anJRTMpSl9M0S63X@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=e.temirgaleev@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v2 1/3] build: fixed making tests with ASAN on OSX' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox