Re: [Tarantool-patches] [PATCH luajit v2 1/3] build: fixed making tests with ASAN on OSX

[Evgeniy Temirgaleev via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

Thanks for review!
I fixed the issues. I shall push the result in the patch v3.
--
Best regards,
Evgeniy Temirgaleev

> 
> From: Sergey Kaplun <skaplun@tarantool.org>
> To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
> Cc: Sergey Bronnikov <sergeyb@tarantool.org>, tarantool-patches@dev.tarantool.org
> 
> Date: Tuesday, August 4, 2026 11:53 PM +03:00
> Sorry, I've noticed some nits regarding the commit message.
> LGTM, after fixing.
> 
> > build: fixed making tests with ASAN on OSX
> 
> It also may use tag `test:`, Feel free to ignore.
> 
> On 31.07.26, Evgeniy Temirgaleev wrote:
> > From: Temir Galeev <temir.galeev@bk.ru>
> >
> > LuaJIT tests use fixup for Linux to run binaries maked with ASAN option.
> 
> 
> Typo: s/maked/made/ or s/maked/built/
> Typo: s/ASAN/the ASAN/
> 
> > The our LibRealPath module used for it. This module doesn't support OSX
> 
> Typo: s/The our/Our/
> Typo: s/used/is used/
> 
> > and breaks the make process.
> >
> > So, we disable the fixup for OSX to allow LuaJIT making and running the
> tests
> 
> Commit message body is more than 72 symbols [1].
> 
> > with ASAN enabled.
> 
> <snipped>
> 
> [1]: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
> 
> 
> --
> Best regards,
> Sergey Kaplun
>

[-- Attachment #2: Type: text/html, Size: 2262 bytes --]