From: Kirill Shcherbatov <kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org, Vladimir Davydov <vdavydov.dev@gmail.com> Subject: Re: [tarantool-patches] [PATCH v3 4/7] lib: update msgpuck library Date: Wed, 3 Apr 2019 20:49:21 +0300 [thread overview] Message-ID: <afcd9afd-3e14-abc1-3857-7c26338fc561@tarantool.org> (raw) In-Reply-To: <d4fbc1ea33c6fe1ed11c73a3c28d653627031203.1554218695.git.kshcherbatov@tarantool.org> Due to changes in the mp_stack API class, we must also fix tuple_format.c In order not to change this code twice, the patch was moved to the position subsequent iterator introduction. Now this is [6/7] patch in patchset. On the branch. ================================================ The msgpack dependency has been updated because the new version introduces the new method mp_stack_top for the mp_stack class which we will use to store a pointer for a multikey frame to initialize a field_map in case of multikey index. As the library API has changed, the code has been modified correspondingly. Needed for #1012 --- src/box/tuple_format.c | 9 +++++---- src/lib/msgpuck | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/box/tuple_format.c b/src/box/tuple_format.c index 9a643b700..7cfdd73bc 100644 --- a/src/box/tuple_format.c +++ b/src/box/tuple_format.c @@ -974,8 +974,8 @@ tuple_parse_iterator_advice(struct tuple_parse_iterator *it, struct tuple_field **field, const char **data, const char **data_end) { - int idx, rc = 0; - while ((idx = mp_stack_advance(&it->stack)) == -1) { + int rc = 0; + while (!mp_frame_advance(mp_stack_top(&it->stack))) { /* * If the elements of the current frame * are over, pop this frame out of stack @@ -993,12 +993,13 @@ tuple_parse_iterator_advice(struct tuple_parse_iterator *it, * current data offset to prepare the JSON token * for the subsequent format::fields lookup. */ + struct mp_frame *frame = mp_stack_top(&it->stack); struct json_token token; - switch (mp_stack_type(&it->stack)) { + switch (frame->type) { case MP_ARRAY: rc = 1; token.type = JSON_TOKEN_NUM; - token.num = idx; + token.num = frame->idx; break; case MP_MAP: rc = 2; diff --git a/src/lib/msgpuck b/src/lib/msgpuck index 222b71aa6..4166d0f77 160000 --- a/src/lib/msgpuck +++ b/src/lib/msgpuck @@ -1 +1 @@ -Subproject commit 222b71aa63e8de6d0015588442d828460560d9be +Subproject commit 4166d0f77496040bcd595d5b02bbf17e7fac5d28 -- 2.21.0
next prev parent reply other threads:[~2019-04-03 17:49 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-02 15:49 [PATCH v3 0/7] box: introduce multikey indexes in memtx Kirill Shcherbatov 2019-04-02 15:49 ` [PATCH v3 1/7] box: cleanup key_def virtual extract_key setter Kirill Shcherbatov 2019-04-03 12:42 ` Vladimir Davydov 2019-04-03 16:22 ` [tarantool-patches] " Kirill Shcherbatov 2019-04-03 18:01 ` Vladimir Davydov 2019-04-02 15:49 ` [PATCH v3 2/7] lib: introduce a new json_path_multikey_offset helper Kirill Shcherbatov 2019-04-03 12:56 ` Vladimir Davydov 2019-04-03 16:22 ` [tarantool-patches] " Kirill Shcherbatov 2019-04-03 18:02 ` Vladimir Davydov 2019-04-04 6:17 ` Konstantin Osipov 2019-04-02 15:49 ` [PATCH v3 3/7] box: move offset_slot init to tuple_format_add_field Kirill Shcherbatov 2019-04-03 12:57 ` Vladimir Davydov 2019-04-03 18:02 ` Vladimir Davydov 2019-04-04 6:19 ` [tarantool-patches] " Konstantin Osipov 2019-04-05 17:17 ` [tarantool-patches] " Kirill Shcherbatov 2019-04-02 15:49 ` [PATCH v3 4/7] lib: update msgpuck library Kirill Shcherbatov 2019-04-03 17:49 ` Kirill Shcherbatov [this message] 2019-04-04 15:54 ` [tarantool-patches] " Vladimir Davydov 2019-04-05 17:17 ` [tarantool-patches] " Kirill Shcherbatov 2019-04-07 12:22 ` Vladimir Davydov 2019-04-02 15:49 ` [PATCH v3 5/7] box: introduce tuple_parse_iterator class Kirill Shcherbatov 2019-04-03 14:04 ` Vladimir Davydov 2019-04-05 17:17 ` [tarantool-patches] " Kirill Shcherbatov 2019-04-02 15:49 ` [PATCH v3 6/7] box: introduce field_map_builder class Kirill Shcherbatov 2019-04-03 14:38 ` Vladimir Davydov 2019-04-05 17:17 ` [tarantool-patches] " Kirill Shcherbatov 2019-04-03 16:30 ` Vladimir Davydov 2019-04-02 15:49 ` [PATCH v3 7/7] box: introduce multikey indexes in memtx Kirill Shcherbatov 2019-04-04 14:20 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=afcd9afd-3e14-abc1-3857-7c26338fc561@tarantool.org \ --to=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [tarantool-patches] [PATCH v3 4/7] lib: update msgpuck library' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox