From: Oleg Babin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Timur Safin <tsafin@tarantool.org>, v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH resend v2 04/11] lua, datetime: display datetime
Date: Sat, 31 Jul 2021 09:29:43 +0300 [thread overview]
Message-ID: <ae8e3a50-40b2-dd90-db61-461cc9edf4b2@tarantool.org> (raw)
In-Reply-To: <044b01d7858c$97b70a70$c7251f50$@tarantool.org>
Thanks for your answers. See my answer below.
On 31.07.2021 00:48, Timur Safin wrote:
> :
> :
> : Also I think that encoding and type system changes should live in
> : separate patches.
>
> I'm not 100% sure that understand this your complain. Could you please
> clarify?
>
Hm... Probably I missed something. As I see now decimal encoding to msgpack
and json/yaml... serializations are in the one patch
(https://github.com/tarantool/tarantool/commit/485439e33196e26d120e622175f88b4edc7a5aa1).
Seems my comment in not relevant, sorry.
next prev parent reply other threads:[~2021-07-31 6:30 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 10:34 [Tarantool-patches] [PATCH resend v2 00/11] Initial datetime support Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 01/11] build: add Christian Hansen c-dt to the build Timur Safin via Tarantool-patches
2021-07-29 23:40 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-31 9:22 ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 02/11] lua: built-in module datetime Timur Safin via Tarantool-patches
2021-07-29 18:55 ` Oleg Babin via Tarantool-patches
2021-07-30 19:00 ` Timur Safin via Tarantool-patches
2021-07-31 6:29 ` Oleg Babin via Tarantool-patches
2021-07-31 16:51 ` Timur Safin via Tarantool-patches
2021-07-29 23:36 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-30 15:39 ` Timur Safin via Tarantool-patches
2021-08-01 17:01 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-01 20:23 ` Timur Safin via Tarantool-patches
2021-08-04 23:57 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 03/11] lua, datetime: datetime tests Timur Safin via Tarantool-patches
2021-07-29 18:55 ` Oleg Babin via Tarantool-patches
2021-07-30 20:45 ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 04/11] lua, datetime: display datetime Timur Safin via Tarantool-patches
2021-07-29 18:55 ` Oleg Babin via Tarantool-patches
2021-07-30 21:48 ` Timur Safin via Tarantool-patches
2021-07-31 6:29 ` Oleg Babin via Tarantool-patches [this message]
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 05/11] box, datetime: add messagepack support for datetime Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 06/11] box, datetime: datetime comparison for indices Timur Safin via Tarantool-patches
2021-07-29 18:56 ` Oleg Babin via Tarantool-patches
2021-07-30 22:18 ` Timur Safin via Tarantool-patches
2021-07-31 6:30 ` Oleg Babin via Tarantool-patches
2021-07-31 9:31 ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 07/11] lua, datetime: proper datetime encoding Timur Safin via Tarantool-patches
2021-07-29 18:57 ` Oleg Babin via Tarantool-patches
2021-07-30 22:20 ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 08/11] lua, datetime: calculated attributes for datetimes Timur Safin via Tarantool-patches
2021-07-29 18:57 ` Oleg Babin via Tarantool-patches
2021-07-30 22:30 ` Timur Safin via Tarantool-patches
2021-07-31 6:31 ` Oleg Babin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 09/11] lua, datetime: time intervals support Timur Safin via Tarantool-patches
2021-07-29 18:58 ` Oleg Babin via Tarantool-patches
2021-07-30 22:58 ` Timur Safin via Tarantool-patches
2021-07-31 6:31 ` Oleg Babin via Tarantool-patches
2021-07-31 9:20 ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 10/11] lua, datetime: unixtime, timestamp setters in datetime.lua Timur Safin via Tarantool-patches
2021-07-29 18:58 ` Oleg Babin via Tarantool-patches
2021-07-30 23:11 ` Timur Safin via Tarantool-patches
2021-07-31 6:31 ` Oleg Babin via Tarantool-patches
2021-07-31 9:54 ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 11/11] datetime: changelog for datetime module Timur Safin via Tarantool-patches
2021-07-29 18:55 ` [Tarantool-patches] [PATCH resend v2 00/11] Initial datetime support Oleg Babin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae8e3a50-40b2-dd90-db61-461cc9edf4b2@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=olegrok@tarantool.org \
--cc=tsafin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH resend v2 04/11] lua, datetime: display datetime' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox