Tarantool development patches archive
 help / color / mirror / Atom feed
From: Timur Safin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "'Oleg Babin'" <olegrok@tarantool.org>, <v.shpilevoy@tarantool.org>
Cc: <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH resend v2 02/11] lua: built-in module datetime
Date: Fri, 30 Jul 2021 22:00:36 +0300
Message-ID: <040c01d78575$2e9dcb80$8bd96280$@tarantool.org> (raw)
In-Reply-To: <2f63968b-490f-9abf-ab36-325553bd7609@tarantool.org>

Hello Oleg,

Thanks for quick review!

: From: Oleg Babin <olegrok@tarantool.org>
: Subject: Re: [Tarantool-patches] [PATCH resend v2 02/11] lua: built-in
: module datetime
: 
: Thanks for your patch!
: 
: 
: Some places from prevous review are still not fixed for some reasons.

Yup, that was oversight due to misunderstanding. Hopefully now I 
Understand it better.

: 
: 
: Please be careful with our Lua style guide I ponted some obvious violations.
: 
: Also it would be great to analyze module functions with our memprof. I
: think there are some places that could be optimized.

Hmm, hmm, probably a good idea. (Assuming using memprof is not a 
rocket science for such relatively newbie in LuaJIT as myself)

...
: 
: > diff --git a/src/lua/datetime.lua b/src/lua/datetime.lua
: > new file mode 100644
: > index 000000000..0996ca5a2
: > --- /dev/null
: > +++ b/src/lua/datetime.lua
: > @@ -0,0 +1,581 @@
: > +local ffi = require('ffi')
: 
: Do we have any benchmarks that shows that FFI is faster than Lua C API?
: 
: Or it's just easy way to implement such module.

Ok, here is a selection list which I've seen:
- decimal is in LuaC;
- uuid is in ffi;

It looked equally acceptable and I've selected the one which is
more convenient - via ffi. Now, you've pointed me to the probable
performance issues we have with ffi, which are not there with LuaC.
I believe they have been fixed with that Mike fix for NYI in
structure allocations (after Sergos dirty fix) and once we will land
this patch to our local fork those performance issues for structures 
allocations will gone.

In any case, 1st version of module is not yet a proper moment to start
to worry about performance, more rather about clarity and quality of API.
We need to return to benchmarking of this code soon after code freeze
lifted.

: 
: 
: > +local cdt = ffi.C
: > +
: > +ffi.cdef [[
: > +
: > +    typedef int dt_t;
: > +
: > +    // dt_core.h
: > +    typedef enum {
: > +        DT_MON       = 1,
: > +        DT_MONDAY    = 1,
: > +        DT_TUE       = 2,
: > +        DT_TUESDAY   = 2,
: > +        DT_WED       = 3,
: > +        DT_WEDNESDAY = 3,
: > +        DT_THU       = 4,
: > +        DT_THURSDAY  = 4,
: > +        DT_FRI       = 5,
: > +        DT_FRIDAY    = 5,
: > +        DT_SAT       = 6,
: > +        DT_SATURDAY  = 6,
: > +        DT_SUN       = 7,
: > +        DT_SUNDAY    = 7,
: > +    } dt_dow_t;
: > +
: > +    dt_t     dt_from_rdn     (int n);
: > +    dt_t     dt_from_yd      (int y, int d);
: > +    dt_t     dt_from_ymd     (int y, int m, int d);
: > +    dt_t     dt_from_yqd     (int y, int q, int d);
: > +    dt_t     dt_from_ywd     (int y, int w, int d);
: > +
: > +    void     dt_to_yd        (dt_t dt, int *y, int *d);
: > +    void     dt_to_ymd       (dt_t dt, int *y, int *m, int *d);
: > +    void     dt_to_yqd       (dt_t dt, int *y, int *q, int *d);
: > +    void     dt_to_ywd       (dt_t dt, int *y, int *w, int *d);
: > +
: > +    int      dt_rdn          (dt_t dt);
: > +    dt_dow_t dt_dow          (dt_t dt);
: > +
: > +    // dt_parse_iso.h
: > +    size_t dt_parse_iso_date          (const char *str, size_t len, dt_t
: *dt);
: > +
: > +    size_t dt_parse_iso_time          (const char *str, size_t len, int
: *sod, int *nsec);
: > +    size_t dt_parse_iso_time_basic    (const char *str, size_t len, int
: *sod, int *nsec);
: > +    size_t dt_parse_iso_time_extended (const char *str, size_t len, int
: *sod, int *nsec);
: > +
: > +    size_t dt_parse_iso_zone          (const char *str, size_t len, int
: *offset);
: > +    size_t dt_parse_iso_zone_basic    (const char *str, size_t len, int
: *offset);
: > +    size_t dt_parse_iso_zone_extended (const char *str, size_t len, int
: *offset);
: > +    size_t dt_parse_iso_zone_lenient  (const char *str, size_t len, int
: *offset);
: > +
: > +    // dt_tm.h
: > +    dt_t    dt_from_struct_tm  (const struct tm *tm);
: > +    void    dt_to_struct_tm    (dt_t dt, struct tm *tm);
: > +
: > +    // <asm-generic/posix_types.h>
: > +    typedef long            __kernel_long_t;
: > +    typedef unsigned long   __kernel_ulong_t;
: > +    // /usr/include/x86_64-linux-gnu/bits/types/time_t.h
: > +    typedef long            time_t;
: > +
: > +
: > +    // <time.h>
: > +    typedef __kernel_long_t	__kernel_time_t;
: > +    typedef __kernel_long_t	__kernel_suseconds_t;
: > +
: > +    struct timespec {
: > +        __kernel_time_t	        tv_sec;     /* seconds */
: > +        long                    tv_nsec;    /* nanoseconds */
: > +    };
: > +
: > +    struct timeval {
: > +        __kernel_time_t	        tv_sec;	    /* seconds */
: > +        __kernel_suseconds_t    tv_usec;    /* microseconds */
: > +    };
: > +
: > +    struct timezone {
: > +        int	tz_minuteswest;     /* minutes west of Greenwich */
: > +        int	tz_dsttime;	        /* type of dst correction */
: > +    };
: > +
: > +    // /usr/include/x86_64-linux-gnu/sys/time.h
: > +    typedef struct timezone * __timezone_ptr_t;
: > +
: > +    /* Get the current time of day and timezone information,
: > +       putting it into *TV and *TZ.  If TZ is NULL, *TZ is not filled.
: > +       Returns 0 on success, -1 on errors.
: > +
: > +       NOTE: This form of timezone information is obsolete.
: > +       Use the functions and variables declared in <time.h> instead.  */
: > +    int gettimeofday (struct timeval *__tv, struct timezone * __tz);
: > +
: > +    // /usr/include/x86_64-linux-gnu/bits/types/struct_tm.h
: > +    /* ISO C `broken-down time' structure.  */
: > +    struct tm
: > +    {
: > +        int tm_sec;	        /* Seconds.	[0-60] (1 leap second) */
: > +        int tm_min;	        /* Minutes.	[0-59] */
: > +        int tm_hour;        /* Hours.	[0-23] */
: > +        int tm_mday;        /* Day.		[1-31] */
: > +        int tm_mon;	        /* Month.	[0-11] */
: > +        int tm_year;        /* Year	- 1900.  */
: > +        int tm_wday;        /* Day of week.	[0-6] */
: > +        int tm_yday;        /* Days in year.[0-365]	*/
: > +        int tm_isdst;       /* DST.		[-1/0/1]*/
: > +
: > +        long int tm_gmtoff; /* Seconds east of UTC.  */
: > +        const char *tm_zone;/* Timezone abbreviation.  */
: > +    };
: > +
: > +    // <time.h>
: > +    /* Return the current time and put it in *TIMER if TIMER is not NULL.
: */
: > +    time_t time (time_t *__timer);
: > +
: > +    /* Format TP into S according to FORMAT.
: > +    Write no more than MAXSIZE characters and return the number
: > +    of characters written, or 0 if it would exceed MAXSIZE.  */
: > +    size_t strftime (char * __s, size_t __maxsize, const char * __format,
: > +                     const struct tm * __tp);
: > +
: > +    /* Parse S according to FORMAT and store binary time information in
: TP.
: > +    The return value is a pointer to the first unparsed character in S.
: */
: > +    char *strptime (const char * __s, const char * __fmt, struct tm
: *__tp);
: > +
: > +    /* Return the `struct tm' representation of *TIMER in UTC,
: > +    using *TP to store the result.  */
: > +    struct tm *gmtime_r (const time_t * __timer, struct tm * __tp);
: > +
: > +    /* Return the `struct tm' representation of *TIMER in local time,
: > +    using *TP to store the result.  */
: > +    struct tm *localtime_r (const time_t * __timer, struct tm * __tp);
: > +
: > +    /* Return a string of the form "Day Mon dd hh:mm:ss yyyy\n"
: > +    that is the representation of TP in this format.  */
: > +    char *asctime (const struct tm *__tp);
: > +
: > +    /* Equivalent to `asctime (localtime (timer))'.  */
: > +    char *ctime (const time_t *__timer);
: > +
: > +]]
: > +
: > +local native = ffi.C
: 
: You've aleady declared cdt as ffi.C. There is a redefinition here. Is it
: really needed.

Thanks for observation - that was copy-paste oversight from external module
code (tsafin/c-dt-ffi), which is not making much sense if module is built-in.

: 
: I don't see anybody use "native" for ffi.C. There are two ways -
: "builtin" and "C".

'builtin` is better, yes. 

: 
: I suppose to choose one of them.
: 
: > +
: > +local SECS_PER_DAY     = 86400
: > +local NANOS_PER_SEC    = 1000000000LL
: > +
: > +-- c-dt/dt_config.h
: > +
: > +-- Unix, January 1, 1970, Thursday
: > +local DT_EPOCH_1970_OFFSET = 719163LL
: 
: To be honest it's not completely clear that such value means until
: 
: I visited
: https://github.com/chansen/c-
: dt/blob/21b8cd1fcb984386b7d4552c16fdd03fafab2b6a/dt_config.h#L50.
: 
: I think some comment is needed here.

Yeah, having explained this same topic to Vlad I now realize it looks
a little bit confusing :)

: 
: 
: > +
: > +
: > +local datetime_t = ffi.typeof('struct datetime_t')
: > +local interval_t = ffi.typeof('struct datetime_interval_t')
: > +
: > +local function interval_new()
: > +    local interval = ffi.new(interval_t)
: > +    return interval
: > +end
: > +
: > +local function adjusted_secs(dt)
: > +    return dt.secs - dt.offset * 60
: > +end
: > +
: > +local function datetime_sub(lhs, rhs)
: > +    local s1 = adjusted_secs(lhs)
: > +    local s2 = adjusted_secs(rhs)
: > +    local d = interval_new()
: > +    d.secs = s2 - s1
: > +    d.nsec = rhs.nsec - lhs.nsec
: > +    if d.nsec < 0 then
: > +        d.secs = d.secs - 1
: > +        d.nsec = d.nsec + NANOS_PER_SEC
: > +    end
: > +    return d
: > +end
: > +
: > +local function datetime_add(lhs, rhs)
: > +    local s1 = adjusted_secs(lhs)
: > +    local s2 = adjusted_secs(rhs)
: > +    local d = interval_new()
: > +    d.secs = s2 + s1
: > +    d.nsec = rhs.nsec + lhs.nsec
: > +    if d.nsec >= NANOS_PER_SEC then
: > +        d.secs = d.secs + 1
: > +        d.nsec = d.nsec - NANOS_PER_SEC
: > +    end
: > +    return d
: > +end
: > +
: > +local function datetime_eq(lhs, rhs)
: > +    -- we usually don't need to check nullness
: > +    -- but older tarantool console will call us checking for equality to
: nil
: > +    if rhs == nil then
: > +        return false
: > +    end
: > +    return (lhs.secs == rhs.secs) and (lhs.nsec == rhs.nsec)
: > +end
: > +
: 
: As in the previous review it will fail on attempt to compare with not
: datetime value.
: 
: tarantool> datetime.new() == newproxy()
: ---
: - error: 'builtin/datetime.lua:222: bad argument #1 to ''is_datetime''
: (C type expected,
:      got userdata)'
: ...
: 
: 
: Expected false.

Understood. Finally!

Here is the code with which I've ended up now:

@@ -292,30 +295,32 @@ local function interval_seconds_new(s)
     return o
 end
 
-local function datetime_eq(lhs, rhs)
-    check_date_interval(lhs, "datetime:__eq(date or interval)")
-    check_date_interval(rhs, "datetime:__eq(date or interval)")
-    return (lhs.secs == rhs.secs) and (lhs.nsec == rhs.nsec)
+local function datetime_cmp(lhs, rhs)
+    if not is_date_interval(lhs) or
+       not is_date_interval(rhs) then
+       return nil
+    end
+    return (lhs.secs - rhs.secs) or (lhs.nsec - rhs.nsec)
 end
 
+local function datetime_eq(lhs, rhs)
+    local rc = datetime_cmp(lhs, rhs) 
+    return rc ~= nil and rc == 0 or false
+end
 
 local function datetime_lt(lhs, rhs)
-    check_date_interval(lhs, "datetime:__lt(date or interval)")
-    check_date_interval(rhs, "datetime:__lt(date or interval)")
-    return (lhs.secs < rhs.secs) or
-           (lhs.secs == rhs.secs and lhs.nsec < rhs.nsec)
+    local rc = datetime_cmp(lhs, rhs) 
+    return rc ~= nil and rc < 0 or false
 end
 
 local function datetime_le(lhs, rhs)
-    check_date_interval(lhs, "datetime:__le(date or interval)")
-    check_date_interval(rhs, "datetime:__le(date or interval)")
-    return (lhs.secs <= rhs.secs) or
-           (lhs.secs == rhs.secs and lhs.nsec <= rhs.nsec)
+    local rc = datetime_cmp(lhs, rhs) 
+    return rc ~= nil and rc <= 0 or false
 end


: 
: 
: > +
: > +local function datetime_lt(lhs, rhs)
: > +    return (lhs.secs < rhs.secs) or
: > +           (lhs.secs == rhs.secs and lhs.nsec < rhs.nsec)
: > +end
: > +
: > +local function datetime_le(lhs, rhs)
: > +    return (lhs.secs <= rhs.secs) or
: > +           (lhs.secs == rhs.secs and lhs.nsec <= rhs.nsec)
: > +end
: > +
: > +local function datetime_serialize(self)
: > +    -- Allow YAML, MsgPack and JSON to dump objects with sockets
: > +    return { secs = self.secs, nsec = self.nsec, tz = self.offset }
: > +end
: > +
: > +local function interval_serialize(self)
: > +    -- Allow YAML and JSON to dump objects with sockets
: > +    return { secs = self.secs, nsec = self.nsec }
: > +end
: > +
: > +local datetime_mt = {
: > +    -- __tostring = datetime_tostring,
: > +    __serialize = datetime_serialize,
: > +    __eq = datetime_eq,
: > +    __lt = datetime_lt,
: > +    __le = datetime_le,
: > +    __sub = datetime_sub,
: > +    __add = datetime_add,
: > +
: > +    nanoseconds = function(self)
: > +        return tonumber(self.secs*NANOS_PER_SEC + self.nsec)
: I think there should be a space before and after "*". Here and below.
: > +    end,
: > +    microseconds = function(self)
: > +        return tonumber(self.secs*1e6 + self.nsec*1e3)
: > +    end,
: > +    seconds = function(self)
: > +        return tonumber(self.secs + self.nsec*1e3)
: > +    end,
: > +    minutes = function(self)
: > +        return tonumber((self._ticks/(1e6*60))%60)
: > +    end,
: > +    hours = function(self)
: > +        return tonumber(self._ticks/(1e6*60*60))
: > +    end,
: > +
: I think this empty line could be removed.
: > +}
: > +
: > +local interval_mt = {
: > +    -- __tostring = interval_tostring,
: > +    __serialize = interval_serialize,
: > +    __eq = datetime_eq,
: > +    __lt = datetime_lt,
: > +    __le = datetime_le,
: > +}
: > +
: > +local function datetime_new_raw(secs, nsec, offset)
: > +    local dt_obj = ffi.new(datetime_t)
: > +    dt_obj.secs = secs
: > +    dt_obj.nsec = nsec
: > +    dt_obj.offset = offset
: > +    return dt_obj
: > +end
: > +
: > +local function local_rd(o)
: > +    return math.floor(tonumber(o.secs / SECS_PER_DAY)) +
: DT_EPOCH_1970_OFFSET
: > +end
: > +
: > +local function local_dt(o)
: > +    return cdt.dt_from_rdn(local_rd(o))
: > +end
: > +
: > +local function mk_timestamp(dt, sp, fp, offset)
: > +    local epochV = dt ~= nil and (cdt.dt_rdn(dt) - DT_EPOCH_1970_OFFSET)
: * SECS_PER_DAY or 0
: > +    local spV = sp ~= nil and sp or 0
: > +    local fpV = fp ~= nil and fp or 0
: > +    local ofsV = offset ~= nil and offset or 0
: > +    return datetime_new_raw (epochV + spV - ofsV * 60, fpV, ofsV)
: > +end
: > +
: > +-- create @datetime_t given object @o fields
: > +local function datetime_new(o)
: > +    if o == nil then
: > +        return datetime_new_raw(0, 0, 0)
: > +    end
: > +    local secs = 0
: > +    local nsec = 0
: > +    local offset = 0
: > +    local easy_way = false

: What does "easy_way" mean?

As I've already tried to explain it to Vlad elsewhere: easy_way means
direct usage of secs/nsec/offset attributed passed for creation of a 
new datetime object, and not parsing of human-readable year/month/day/
hour/minute/seconds attributes it has to deal with otherwise.

: > +    local y, M, d, ymd
: > +    y, M, d, ymd = 0, 0, 0, false
: > +
: > +    local h, m, s, frac, hms
: > +    h, m, s, frac, hms = 0, 0, 0, 0, false
: > +
: > +    local dt = 0
: > +
: > +    for key, value in pairs(o) do
: > +        local handlers = {
: 
: Here you recreate handlers for each iteration of the loop. I think it
: should be reworked.

Yes, let me check how better will be if this handlers array will be invariant
in the loop, and not created each iteration.

I still prefer this tag to function approach because of a better clarity,
but I need to verify in benchmark whether it provides acceptable performance.

I do not expect thought that this attribute object creation approach would become
a bootleneck in any case and might be on a critical path anywhere (I'd rather expect 
it for datetime objects created after parsing of massive bunch of log text), 
but need to look into timings we would have with invariant table.

: 
: Currenlty it's quite slow I think even if-elseif-else branches will work
: faster without
: 
: creating redundant GC objects.

Will see ...

: 
: > +            secs = function(v)
: > +                secs = v
: > +                easy_way = true
: > +            end,
: > +
: > +            nsec = function(v)
: > +                nsec = v
: > +                easy_way = true
: > +            end,
: > +
: > +            offset = function (v)
: > +                offset = v
: > +                easy_way = true
: > +            end,
: > +
: > +            year = function(v)
: > +                assert(v > 0 and v < 10000)
: Still there are some assertions that yield unclear error messages.

They have been already reworked in a later patches of patchset. 
[Probably better to squash them all for datetime.lua, yes]

: > +                y = v
: > +                ymd = true
: > +            end,
: > +
: > +            month = function(v)
: > +                assert(v > 0 and v < 12 )
: > +                M = v
: > +                ymd = true
: > +            end,
: > +
: > +            day = function(v)
: > +                assert(v > 0 and v < 32)
: > +                d = v
: > +                ymd = true
: > +            end,
: > +
: > +            hour = function(v)
: > +                assert(v >= 0 and v < 24)
: > +                h = v
: > +                hms = true
: > +            end,
: > +
: > +            minute = function(v)
: > +                assert(v >= 0 and v < 60)
: > +                m = v
: > +                hms = true
: > +            end,
: > +
: > +            second = function(v)
: > +                assert(v >= 0 and v < 61)
: > +                frac = v % 1
: > +                if frac then
: > +                    s = v - (v % 1)
: > +                else
: > +                    s = v
: > +                end
: > +                hms = true
: > +            end,
: > +
: > +            -- tz offset in minutes
: > +            tz = function(v)
: > +                assert(v >= 0 and v <= 720)
: > +                offset = v
: > +            end
: > +        }
: > +        handlers[key](value)
: > +    end
: > +
: > +    -- .sec, .nsec, .offset
: > +    if easy_way then
: > +        return datetime_new_raw(secs, nsec, offset)
: > +    end
: > +
: > +    -- .year, .month, .day
: > +    if ymd then
: > +        dt = dt + cdt.dt_from_ymd(y, M, d)
: > +    end
: > +
: > +    -- .hour, .minute, .second
: > +    if hms then
: > +        secs = h * 3600 + m * 60 + s
: > +    end
: > +
: > +    return mk_timestamp(dt, secs, frac, offset)
: > +end
: > +
: > +
: > +-- simple parse functions:
: > +-- parse_date/parse_time/parse_zone
: > +
: > +--[[
: > +    Basic      Extended
: > +    20121224   2012-12-24   Calendar date   (ISO 8601)
: > +    2012359    2012-359     Ordinal date    (ISO 8601)
: > +    2012W521   2012-W52-1   Week date       (ISO 8601)
: > +    2012Q485   2012-Q4-85   Quarter date
: > +]]
: > +
: > +local function parse_date(str)
: > +    local dt = ffi.new('dt_t[1]')
: > +    local rc = cdt.dt_parse_iso_date(str, #str, dt)
: > +    assert(rc > 0)
: > +    return mk_timestamp(dt[0])
: > +end
: > +
: > +--[[
: > +    Basic               Extended
: > +    T12                 N/A
: > +    T1230               T12:30
: > +    T123045             T12:30:45
: > +    T123045.123456789   T12:30:45.123456789
: > +    T123045,123456789   T12:30:45,123456789
: > +
: > +    The time designator [T] may be omitted.
: > +]]
: > +local function parse_time(str)
: > +    local sp = ffi.new('int[1]')
: > +    local fp = ffi.new('int[1]')
: > +    local rc = cdt.dt_parse_iso_time(str, #str, sp, fp)
: > +    assert(rc > 0)
: > +    return mk_timestamp(nil, sp[0], fp[0])
: > +end
: > +
: > +--[[
: > +    Basic    Extended
: > +    Z        N/A
: > +    ±hh      N/A
: > +    ±hhmm    ±hh:mm
: > +]]
: > +local function parse_zone(str)
: > +    local offset = ffi.new('int[1]')
: > +    local len = cdt.dt_parse_iso_zone_lenient(str, #str, offset)
: > +    return len > 0 and mk_timestamp(nil, nil, nil, offset[0]) or nil,
: tonumber(len)
: > +end
: > +
: > +
: > +--[[
: > +    aggregated parse functions
: > +    assumes to deal with date T time time_zone
: > +    at once
: > +
: > +    date [T] time [ ] time_zone
: > +]]
: > +local function parse_str(str)
: > +    local dt = ffi.new('dt_t[1]')
: > +    local len = #str
: > +    local n = cdt.dt_parse_iso_date(str, len, dt)
: > +    local dt_ = dt[0]
: > +    if n == 0 or len == n then
: > +        return mk_timestamp(dt_)
: > +    end
: > +
: > +    str = str:sub(tonumber(n) + 1)
: > +
: > +    local ch = str:sub(1,1)
: > +    if ch ~= 't' and ch ~= 'T' and ch ~= ' ' then
: > +        return mk_timestamp(dt_)
: > +    end
: > +
: > +    str = str:sub(2)
: > +    len = #str
: > +
: > +    local sp = ffi.new('int[1]')
: > +    local fp = ffi.new('int[1]')
: > +    local n = cdt.dt_parse_iso_time(str, len, sp, fp)
: > +    if n == 0 then
: > +        return mk_timestamp(dt_)
: > +    end
: > +    local sp_ = sp[0]
: > +    local fp_ = fp[0]
: > +    if len == n then
: > +        return mk_timestamp(dt_, sp_, fp_)
: > +    end
: > +
: > +    str = str:sub(tonumber(n) + 1)
: > +
: > +    if str:sub(1,1) == ' ' then
: > +        str = str:sub(2)
: > +    end
: > +
: > +    len = #str
: > +
: > +    local offset = ffi.new('int[1]')
: > +    n = cdt.dt_parse_iso_zone_lenient(str, len, offset)
: > +    if n == 0 then
: > +        return mk_timestamp(dt_, sp_, fp_)
: > +    end
: > +    return mk_timestamp(dt_, sp_, fp_, offset[0])
: > +end
: > +
: > +local function datetime_from(o)
: > +    if o == nil or type(o) == 'table' then
: > +        return datetime_new(o)
: > +    elseif type(o) == 'string' then
: > +        return parse_str(o)
: > +    end
: > +end
: > +
: > +local function local_now()
: > +    local p_tv = ffi.new ' struct timeval [1] '
: 
: This line doesn't conform our code-style. Please wrap argument into
: brackets.

Yes, sorry. But for consistency with surrounding code I've put it
inside of parentheses.

: 
: The same for such places below.
: 
: > +    local rc = native.gettimeofday(p_tv, nil)
: > +    assert(rc == 0)
: > +
: > +    local secs = p_tv[0].tv_sec
: > +    local nsec = p_tv[0].tv_usec * 1000
: > +
: > +    local p_time = ffi.new 'time_t[1]'
: > +    local p_tm = ffi.new 'struct tm[1]'
: > +    native.time(p_time)
: > +    native.localtime_r(p_time, p_tm)
: > +    -- local dt = cdt.dt_from_struct_tm(p_tm)
: > +    local ofs = p_tm[0].tm_gmtoff / 60 -- convert seconds to minutes
: > +
: > +    return datetime_new_raw(secs, nsec, ofs) -- FIXME

: Do you plan to fix it before merge?

Thanks for spot! Done.

: > +end
: > +
: > +local function datetime_to_tm_ptr(o)
: > +    local p_tm = ffi.new 'struct tm[1]'
: > +    assert(ffi.typeof(o) == datetime_t)
: > +    -- dt_to_struct_tm() fills only date data
: > +    cdt.dt_to_struct_tm(local_dt(o), p_tm)
: > +
: > +    -- calculate the smaller data (hour, minute,
: > +    -- seconds) using datetime seconds value
: > +    local seconds_of_day = o.secs % 86400
: > +    local hour = (seconds_of_day / 3600) % 24
: > +    local minute = (seconds_of_day / 60) % 60
: > +    p_tm[0].tm_sec = seconds_of_day % 60
: > +    p_tm[0].tm_min = minute
: > +    p_tm[0].tm_hour = hour
: > +
: > +    p_tm[0].tm_gmtoff = o.offset * 60
: > +
: > +    return p_tm
: > +end
: > +
: > +local function asctime(o)
: > +    assert(ffi.typeof(o) == datetime_t)
: > +    local p_tm = datetime_to_tm_ptr(o)
: > +    return ffi.string(native.asctime(p_tm))
: > +end
: > +
: > +local function ctime(o)
: > +    assert(ffi.typeof(o) == datetime_t)
: > +    local p_time = ffi.new 'time_t[1]'
: > +    p_time[0] = o.secs
: > +    return ffi.string(native.ctime(p_time))
: > +end
: > +
: > +local function strftime(fmt, o)
: > +    assert(ffi.typeof(o) == datetime_t)
: > +    local sz = 50
: Why 50?

Good question, for ISO-8601 formats, for normal date range 
(from 0000 till 9999 years) it's more like closer to 40, but 
well, there will be various timezones and all crazy kinds of 
input format combinations, so we need to either be precautious 
with larger sizes allocations.

Or probably rely on glibc convention (which is apparently not in 
POSIX/SUSV) with 2 passes approach:
1. call with NULL so it will return size of required buffer;
2. then, after allocation, with the adjusted allocated buffer;

https://www.gnu.org/software/libc/manual/html_node/Formatting-Calendar-Time.html
https://pubs.opengroup.org/onlinepubs/000095399/functions/strftime.html

Something like that (beware of inline patch):

----------------------------------------------
local function strftime(fmt, o)
     check_date(o, "datetime.strftime(fmt, date)")
-    local sz = 50
-    local buff = ffi.new('char[?]', sz)
     local p_tm = datetime_to_tm_ptr(o)
-    native.strftime(buff, sz, fmt, p_tm)
+    local sz = builtin.strftime(nil, 1024, fmt, p_tm)
+    local buff = ffi.new('char[?]', sz + 1)
+    builtin.strftime(buff, sz, fmt, p_tm)
     return ffi.string(buff)
 end
----------------------------------------------

: > +    local buff = ffi.new('char[?]', sz)
: > +    local p_tm = datetime_to_tm_ptr(o)
: > +    native.strftime(buff, sz, fmt, p_tm)
: > +    return ffi.string(buff)
: > +end
: > +
: > +-- strftime may be redirected to datetime:fmt("format")
: > +local function datetime_fmt()
: > +end
: > +
: > +
: > +ffi.metatype(interval_t, interval_mt)
: > +ffi.metatype(datetime_t, datetime_mt)
: > +
: > +return setmetatable(
: > +    {
: > +        datetime = datetime_new,
: > +        interval = interval_new,
: > +
: > +        parse = parse_str,
: > +        parse_date = parse_date,
: > +        parse_time = parse_time,
: > +        parse_zone = parse_zone,
: > +        fmt = datetime_fmt,
: > +
: > +        now = local_now,
: > +    -- strptime = strptime;
: It should be dropped if you don't need it.
: > +        strftime = strftime,
: > +        asctime = asctime,
: > +        ctime = ctime,
: > +    }, {
: > +        __call = function(self, ...) return datetime_from(...) end
: > +    }
: > +)

Thanks,
Timur


  reply	other threads:[~2021-07-30 19:00 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 10:34 [Tarantool-patches] [PATCH resend v2 00/11] Initial datetime support Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 01/11] build: add Christian Hansen c-dt to the build Timur Safin via Tarantool-patches
2021-07-29 23:40   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-31  9:22     ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 02/11] lua: built-in module datetime Timur Safin via Tarantool-patches
2021-07-29 18:55   ` Oleg Babin via Tarantool-patches
2021-07-30 19:00     ` Timur Safin via Tarantool-patches [this message]
2021-07-31  6:29       ` Oleg Babin via Tarantool-patches
2021-07-31 16:51         ` Timur Safin via Tarantool-patches
2021-07-29 23:36   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-30 15:39     ` Timur Safin via Tarantool-patches
2021-08-01 17:01       ` Vladislav Shpilevoy via Tarantool-patches
2021-08-01 20:23         ` Timur Safin via Tarantool-patches
2021-08-04 23:57           ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 03/11] lua, datetime: datetime tests Timur Safin via Tarantool-patches
2021-07-29 18:55   ` Oleg Babin via Tarantool-patches
2021-07-30 20:45     ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 04/11] lua, datetime: display datetime Timur Safin via Tarantool-patches
2021-07-29 18:55   ` Oleg Babin via Tarantool-patches
2021-07-30 21:48     ` Timur Safin via Tarantool-patches
2021-07-31  6:29       ` Oleg Babin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 05/11] box, datetime: add messagepack support for datetime Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 06/11] box, datetime: datetime comparison for indices Timur Safin via Tarantool-patches
2021-07-29 18:56   ` Oleg Babin via Tarantool-patches
2021-07-30 22:18     ` Timur Safin via Tarantool-patches
2021-07-31  6:30       ` Oleg Babin via Tarantool-patches
2021-07-31  9:31         ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 07/11] lua, datetime: proper datetime encoding Timur Safin via Tarantool-patches
2021-07-29 18:57   ` Oleg Babin via Tarantool-patches
2021-07-30 22:20     ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 08/11] lua, datetime: calculated attributes for datetimes Timur Safin via Tarantool-patches
2021-07-29 18:57   ` Oleg Babin via Tarantool-patches
2021-07-30 22:30     ` Timur Safin via Tarantool-patches
2021-07-31  6:31       ` Oleg Babin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 09/11] lua, datetime: time intervals support Timur Safin via Tarantool-patches
2021-07-29 18:58   ` Oleg Babin via Tarantool-patches
2021-07-30 22:58     ` Timur Safin via Tarantool-patches
2021-07-31  6:31       ` Oleg Babin via Tarantool-patches
2021-07-31  9:20         ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 10/11] lua, datetime: unixtime, timestamp setters in datetime.lua Timur Safin via Tarantool-patches
2021-07-29 18:58   ` Oleg Babin via Tarantool-patches
2021-07-30 23:11     ` Timur Safin via Tarantool-patches
2021-07-31  6:31       ` Oleg Babin via Tarantool-patches
2021-07-31  9:54         ` Timur Safin via Tarantool-patches
2021-07-28 10:34 ` [Tarantool-patches] [PATCH resend v2 11/11] datetime: changelog for datetime module Timur Safin via Tarantool-patches
2021-07-29 18:55 ` [Tarantool-patches] [PATCH resend v2 00/11] Initial datetime support Oleg Babin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='040c01d78575$2e9dcb80$8bd96280$@tarantool.org' \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=olegrok@tarantool.org \
    --cc=tsafin@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git