From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 3/3] test: add replication/gh-5446-sqync-eval-quorum.test.lua
Date: Wed, 25 Nov 2020 16:57:20 +0300 [thread overview]
Message-ID: <ae36691a-402b-829a-ae11-dd78fdbbf02b@tarantool.org> (raw)
In-Reply-To: <20201124152405.1174898-4-gorcunov@gmail.com>
24.11.2020 18:24, Cyrill Gorcunov пишет:
> Part-of #5446
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> .../gh-5446-sqync-eval-quorum.result | 156 ++++++++++++++++++
> .../gh-5446-sqync-eval-quorum.test.lua | 62 +++++++
> test/replication/replica-quorum-1.lua | 1 +
> test/replication/replica-quorum-2.lua | 1 +
> test/replication/replica-quorum-3.lua | 1 +
> test/replication/replica-quorum-4.lua | 1 +
> test/replication/replica-quorum.lua | 13 ++
> 7 files changed, 235 insertions(+)
> create mode 100644 test/replication/gh-5446-sqync-eval-quorum.result
> create mode 100644 test/replication/gh-5446-sqync-eval-quorum.test.lua
> create mode 120000 test/replication/replica-quorum-1.lua
> create mode 120000 test/replication/replica-quorum-2.lua
> create mode 120000 test/replication/replica-quorum-3.lua
> create mode 120000 test/replication/replica-quorum-4.lua
> create mode 100644 test/replication/replica-quorum.lua
This patch LGTM with one comment.
AFAIU you may use replica.lua for this test.
--
Serge Petrenko
next prev parent reply other threads:[~2020-11-25 13:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 15:24 [Tarantool-patches] [PATCH v2 0/3] qsync: evaluate replication_synchro_quorum dynamically Cyrill Gorcunov
2020-11-24 15:24 ` [Tarantool-patches] [PATCH v2 1/3] cfg: add cfg_isnumber helper Cyrill Gorcunov
2020-11-24 15:24 ` [Tarantool-patches] [PATCH v2 2/3] cfg: support symbolic evaluation of replication_synchro_quorum Cyrill Gorcunov
2020-11-25 11:36 ` Serge Petrenko
2020-11-25 11:55 ` Cyrill Gorcunov
2020-11-25 12:10 ` Serge Petrenko
2020-11-25 12:19 ` Cyrill Gorcunov
2020-11-25 12:04 ` Serge Petrenko
2020-11-25 12:12 ` Cyrill Gorcunov
2020-11-25 12:46 ` Serge Petrenko
2020-11-25 12:53 ` Cyrill Gorcunov
2020-11-25 13:49 ` Serge Petrenko
2020-11-24 15:24 ` [Tarantool-patches] [PATCH v2 3/3] test: add replication/gh-5446-sqync-eval-quorum.test.lua Cyrill Gorcunov
2020-11-25 13:57 ` Serge Petrenko [this message]
2020-11-25 14:10 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae36691a-402b-829a-ae11-dd78fdbbf02b@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 3/3] test: add replication/gh-5446-sqync-eval-quorum.test.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox