From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4CB08469710 for ; Wed, 25 Nov 2020 16:57:21 +0300 (MSK) References: <20201124152405.1174898-1-gorcunov@gmail.com> <20201124152405.1174898-4-gorcunov@gmail.com> From: Serge Petrenko Message-ID: Date: Wed, 25 Nov 2020 16:57:20 +0300 MIME-Version: 1.0 In-Reply-To: <20201124152405.1174898-4-gorcunov@gmail.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH v2 3/3] test: add replication/gh-5446-sqync-eval-quorum.test.lua List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Cc: Vladislav Shpilevoy 24.11.2020 18:24, Cyrill Gorcunov пишет: > Part-of #5446 > > Signed-off-by: Cyrill Gorcunov > --- > .../gh-5446-sqync-eval-quorum.result | 156 ++++++++++++++++++ > .../gh-5446-sqync-eval-quorum.test.lua | 62 +++++++ > test/replication/replica-quorum-1.lua | 1 + > test/replication/replica-quorum-2.lua | 1 + > test/replication/replica-quorum-3.lua | 1 + > test/replication/replica-quorum-4.lua | 1 + > test/replication/replica-quorum.lua | 13 ++ > 7 files changed, 235 insertions(+) > create mode 100644 test/replication/gh-5446-sqync-eval-quorum.result > create mode 100644 test/replication/gh-5446-sqync-eval-quorum.test.lua > create mode 120000 test/replication/replica-quorum-1.lua > create mode 120000 test/replication/replica-quorum-2.lua > create mode 120000 test/replication/replica-quorum-3.lua > create mode 120000 test/replication/replica-quorum-4.lua > create mode 100644 test/replication/replica-quorum.lua This patch LGTM with one comment. AFAIU you may use replica.lua for this test. -- Serge Petrenko