Re: [Tarantool-patches] [PATCH v4 00/12] raft: introduce manual elections and fix a bug with re-applying rolled back transactions

[Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

21.04.2021 01:30, Vladislav Shpilevoy пишет:
> I pushed my fixes to this branch: sp/gh-5445-election-fixes-review
> as separate commits among your commits.

Thanks! I squashed all of your fixes on sp/gh-5445-election-fixes-review

>
> It does not mean the patch is perfect for push, we still have
> known issues with absence of tests, and some moments we still need
> to fix such as:
>
> - Limbo ownership should not change automatically. This is the only
>    way to make it more or less stable;
>
> - The NOP filter should work regardless of election mode. Otherwise
>    we still have 5445 issue when it is off;
>
> - There are no tests for the NOP filter not working for election off;
>    for a few places in box.cc in box.ctl.promote();
>    for why in the NOP filter we must use txn origin ID instead of applier
>    instance ID. This might lead to data loss if we did something wrong.

I agree.

> My commits are marked as [tosquash].
>
> For the problems above I will create tickets if the patch is pushed as
> in the branch sp/gh-5445-election-fixes-review.

-- 
Serge Petrenko