From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7272C6EC5F; Wed, 21 Apr 2021 09:01:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7272C6EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618984885; bh=yqCa9sK8IZ2EYJGg5A0jQHjfUh3RaMrzEkZ4ZsctP1o=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=iTwBoosZlvtWlAW9z8AXKIeRgZjMalLCdx4pMwyWXmMDQOK1DMMopjObVIf7DuNc1 M4FEZjf1IyO5urbtqlwzydhCe83X/sJ/ngKW7rcQa1qXzGsvlpIASTnzUD/lHDyXP7 o0xcl2jy8IsVXBzuFKS2LqnNcX5f8IHryG0/wdI0= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8A4C16EC5F for ; Wed, 21 Apr 2021 09:01:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8A4C16EC5F Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1lZ5vP-0002bt-T6; Wed, 21 Apr 2021 09:01:24 +0300 To: Vladislav Shpilevoy , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: <3374fc86-12fe-0d9c-4b50-d3535edd9be7@tarantool.org> Message-ID: Date: Wed, 21 Apr 2021 09:01:23 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <3374fc86-12fe-0d9c-4b50-d3535edd9be7@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480257C85EA0BB7A95D5E28B957962BB550182A05F5380850403DA69B7D117681D04EA822DC9138EFF997D8B76B9AFEBE256EDA51CAAEF2CF0C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371A4E0E763A740679EA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA658A399D317F737F038FC0C433F4F7E2CCFF6B57BC7E64490618DEB871D839B73339E8FC8737B5C224936DA1BED736F9328CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0F60A601881DBAB3C8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD2691661749BA6B9773500CAF848F062779D7B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050FB28585415E75ADA9EA93887B71B66F2BB3661434B16C20AC78D18283394535A9E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9149C560DC76099D75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5D85F13332D71C66D7231048CCF72AE7676F609C04A8CA251D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3438BC6CF312DA7315EBEE383A97736BFCBD505650D49E1BD8A22F318A1FCE3986D124CF9B8B85D9641D7E09C32AA3244CF3D76D78078BF373D11F39CA6B21F694CE0B41342B755BCDFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojlPRl29Bx4WG9RrXG8jXClQ== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F82AD6EEB6DB1C3386568F431BC3E95DC32616140F0E833F8C424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 00/12] raft: introduce manual elections and fix a bug with re-applying rolled back transactions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 21.04.2021 01:30, Vladislav Shpilevoy пишет: > I pushed my fixes to this branch: sp/gh-5445-election-fixes-review > as separate commits among your commits. Thanks! I squashed all of your fixes on sp/gh-5445-election-fixes-review > > It does not mean the patch is perfect for push, we still have > known issues with absence of tests, and some moments we still need > to fix such as: > > - Limbo ownership should not change automatically. This is the only > way to make it more or less stable; > > - The NOP filter should work regardless of election mode. Otherwise > we still have 5445 issue when it is off; > > - There are no tests for the NOP filter not working for election off; > for a few places in box.cc in box.ctl.promote(); > for why in the NOP filter we must use txn origin ID instead of applier > instance ID. This might lead to data loss if we did something wrong. I agree. > My commits are marked as [tosquash]. > > For the problems above I will create tickets if the patch is pushed as > in the branch sp/gh-5445-election-fixes-review. -- Serge Petrenko