From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 1/4] box: introduce new helpers in column_mask.h
Date: Fri, 22 Feb 2019 20:51:37 +0300 [thread overview]
Message-ID: <ad7b1616-e04d-2491-f84b-babe732d64fb@tarantool.org> (raw)
In-Reply-To: <d3719543-0ba9-1913-50a2-79a6f6dff333@tarantool.org>
Hi! Thanks for the fixes!
Once you introduced the new helpers, please, use them.
I found raw column mask usage in sql_space_column_is_in_pk().
Also, the first two hunks from the next commit does not
belong to the bug, so please, move them here (I speak about
alter.cc changes).
next prev parent reply other threads:[~2019-02-22 17:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 12:52 [tarantool-patches] [PATCH v1 0/4] sql: replace 32 bit column mask Kirill Shcherbatov
2019-02-08 12:52 ` [tarantool-patches] [PATCH v1 1/4] box: introduce new helpers in column_mask.h Kirill Shcherbatov
2019-02-15 17:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-20 13:42 ` Kirill Shcherbatov
2019-02-22 17:51 ` Vladislav Shpilevoy [this message]
2019-02-22 18:01 ` Konstantin Osipov
2019-02-22 18:22 ` Konstantin Osipov
2019-02-08 12:52 ` [tarantool-patches] [PATCH v1 2/4] sql: use 64b bitmasks instead of 32b where possible Kirill Shcherbatov
2019-02-15 17:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-20 13:42 ` Kirill Shcherbatov
2019-02-08 12:52 ` [tarantool-patches] [PATCH v1 3/4] sql: got rid of redundant MASKBIT32 definition Kirill Shcherbatov
2019-02-15 17:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-20 13:42 ` Kirill Shcherbatov
2019-02-08 12:52 ` [tarantool-patches] [PATCH v1 4/4] sql: got rid of redundant bitmask helpers Kirill Shcherbatov
2019-02-15 17:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-20 13:42 ` Kirill Shcherbatov
2019-02-22 17:52 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad7b1616-e04d-2491-f84b-babe732d64fb@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/4] box: introduce new helpers in column_mask.h' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox