Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
	Mergen Imeev <imeevma@tarantool.org>,
	Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 1/2] lua: new function luaT_return_error()
Date: Thu, 1 Aug 2019 22:03:42 +0200	[thread overview]
Message-ID: <ac5f2650-4fd2-9e97-c42e-2b85a7e08301@tarantool.org> (raw)
In-Reply-To: <20190731221639.GA16655@tarantool.org>

Hi! Thanks for the fixes!

I've force pushed this:

===========================================================================
diff --git a/src/lua/fio.c b/src/lua/fio.c
index e5d3458fd..7437cc0c6 100644
--- a/src/lua/fio.c
+++ b/src/lua/fio.c
@@ -49,7 +49,7 @@
 
 #define lbox_fio_pushsyserror(L) ({				\
 	diag_set(SystemError, "fio: %s", strerror(errno));	\
-	luaT_push_nil_and_error(L);					\
+	luaT_push_nil_and_error(L);				\
 })
 
 static int
===========================================================================

Now the patchset LGTM. Kirill, please, push.

  reply	other threads:[~2019-08-01 20:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 10:32 [tarantool-patches] [PATCH v2 0/2] sql: rework error handling in box.execute() imeevma
2019-07-31 10:32 ` [tarantool-patches] [PATCH v2 1/2] lua: new function luaT_return_error() imeevma
2019-07-31 15:23   ` [tarantool-patches] " Alexander Turenko
2019-07-31 15:39     ` Konstantin Osipov
2019-07-31 15:40     ` Vladislav Shpilevoy
2019-07-31 16:20       ` Imeev Mergen
2019-07-31 17:00         ` Vladislav Shpilevoy
2019-07-31 19:33           ` Konstantin Osipov
2019-08-01  8:35           ` Alexander Turenko
2019-07-31 19:32         ` Konstantin Osipov
2019-07-31 17:15   ` Vladislav Shpilevoy
2019-07-31 22:16     ` Mergen Imeev
2019-08-01 20:03       ` Vladislav Shpilevoy [this message]
2019-08-01  8:59     ` Mergen Imeev
2019-07-31 10:32 ` [tarantool-patches] [PATCH v2 2/2] sql: rework error handling in box.execute() imeevma
2019-07-31 22:23   ` [tarantool-patches] " Mergen Imeev
2019-08-02  5:39 ` [tarantool-patches] Re: [PATCH v2 0/2] " Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac5f2650-4fd2-9e97-c42e-2b85a7e08301@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v2 1/2] lua: new function luaT_return_error()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox