[tarantool-patches] Re: [PATCH v3 00/10] sql: remove Triggers to server

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Now the patchset LGTM.

Nikita, please, review.

On 14/06/2018 20:32, Kirill Shcherbatov wrote:
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3273-no-sql-triggers
> Issue: https://github.com/tarantool/tarantool/issues/3273
> 
> Kirill Shcherbatov (10):
>    box: move db->pShchema init to sql_init
>    sql: fix leak on CREATE TABLE and resolve self ref
>    sql: fix sql len in tarantoolSqlite3RenameTrigger
>    box: port schema_find_id to C
>    sql: refactor sql_expr_compile to return AST
>    sql: move sqlite3DeleteTrigger to sql.h
>    box: sort error codes in misc.test
>    sql: new  _trigger space format with space_id
>    sql: move Triggers to server
>    sql: VDBE tests for trigger existence
> 
>   src/box/alter.cc                                   | 134 ++++++++-
>   src/box/bootstrap.snap                             | Bin 1698 -> 1704 bytes
>   src/box/errcode.h                                  |   2 +-
>   src/box/lua/schema.lua                             |   4 +
>   src/box/lua/upgrade.lua                            |   4 +
>   src/box/schema.cc                                  |  54 +++-
>   src/box/schema.h                                   |  23 +-
>   src/box/schema_def.h                               |   6 +
>   src/box/space.c                                    |   5 +
>   src/box/space.h                                    |   2 +
>   src/box/sql.c                                      |  85 ++----
>   src/box/sql.h                                      |  66 ++++-
>   src/box/sql/build.c                                |  59 +++-
>   src/box/sql/callback.c                             |   7 +-
>   src/box/sql/fkey.c                                 |   2 -
>   src/box/sql/insert.c                               |   6 +-
>   src/box/sql/main.c                                 |  10 +-
>   src/box/sql/prepare.c                              |   2 +
>   src/box/sql/sqliteInt.h                            |  30 +-
>   src/box/sql/status.c                               |   6 +-
>   src/box/sql/tokenize.c                             |  50 +++-
>   src/box/sql/trigger.c                              | 320 ++++++++++----------
>   src/box/sql/vdbe.c                                 |  87 ++----
>   src/box/sql/vdbe.h                                 |   3 +-
>   src/box/sql/vdbeapi.c                              |   5 +-
>   src/box/sql/vdbeaux.c                              |  13 +-
>   src/box/user.cc                                    |   4 +-
>   src/diag.h                                         |   3 +
>   test/app-tap/tarantoolctl.test.lua                 |   2 +-
>   test/box-py/bootstrap.result                       |   5 +-
>   test/box/access_misc.result                        |   4 +-
>   test/box/access_sysview.result                     |   4 +-
>   test/box/alter.result                              |   1 +
>   test/box/misc.result                               | 326 +++++++++++----------
>   test/box/misc.test.lua                             |   4 +-
>   test/engine/iterator.result                        |   2 +-
>   test/sql-tap/identifier_case.test.lua              |   4 +-
>   test/sql-tap/trigger1.test.lua                     |  14 +-
>   test/sql/gh2141-delete-trigger-drop-table.result   |   4 +-
>   test/sql/gh2141-delete-trigger-drop-table.test.lua |   4 +-
>   test/sql/persistency.result                        |   8 +-
>   test/sql/persistency.test.lua                      |   8 +-
>   test/sql/triggers.result                           | 255 ++++++++++++++++
>   test/sql/triggers.test.lua                         |  92 ++++++
>   test/sql/upgrade.result                            |  37 ++-
>   test/sql/upgrade.test.lua                          |   9 +-
>   46 files changed, 1205 insertions(+), 570 deletions(-)
>   create mode 100644 test/sql/triggers.result
>   create mode 100644 test/sql/triggers.test.lua
>